Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding remaining EEA-direct sources #707

Merged
merged 7 commits into from
Apr 20, 2020
Merged

Adding remaining EEA-direct sources #707

merged 7 commits into from
Apr 20, 2020

Conversation

magsyg
Copy link
Contributor

@magsyg magsyg commented Apr 17, 2020

This push has made these sources pull from EEA

  • Bulgaria
  • Cyprus
  • Georgia
  • Greece
  • Romania

Closes #677

Copy link
Contributor

@sruti sruti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! A couple of things:

  1. For countries that already have sources (like UK, Slovenia, Iceland etc), it would be great to check if the EEA data is different than the data we already have. It doesn't make sense to have duplicate data and since EEA gets the data from regional sources, I suspect they may be the same. For example in the UK, EEA files list the network_namespace as http://environment.data.gov.uk/air-quality/so which is DEFRA, the source we already have for the UK. So it's safe to say we won't need data from EEA for that one (and with Brexit who knows...)
  2. I checked out Bulgaria, Cypress, Greece, and Romania. All of those are working properly. If you break these out into another PR I can merge them in while you're investigating the others. This way, fetch isn't suddenly ingesting a ton more data and it's easier to debug.
    Thanks!

.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
sources/ee.json Outdated Show resolved Hide resolved
@magsyg magsyg requested a review from sruti April 18, 2020 14:00
@magsyg
Copy link
Contributor Author

magsyg commented Apr 20, 2020

I checked out the other EEA sources for countries which already have sources. EEA for Iceland, Great Britain, Norway, Netherlands and Slovenia seemed to be complete duplicates of the already existing sources. Bosnia's EEA source did not seem to work, The EEA sources of Italy and Poland seemed to have some of the same values, but it looked like the EEA sources had a lot of more stations than the existing sources. Sweden's source did not load anything, could be a problem with the adapter, but the EEA source does seem to provde a lot more stations than the existing swedish source, which only has airdata from Stockholm, not the rest of sweden

Copy link
Contributor

@sruti sruti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this but noting that we're not actually pulling in data for Georgia because its stations don't exist in the list of EEA stations

@sruti sruti merged commit 6d9c84c into openaq:develop Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Several countries in EEA we are not pulling
2 participants