Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Commit

Permalink
Initial support for Group Replication - Addressing PR comments
Browse files Browse the repository at this point in the history
* Remove no longer needed `WaitGroup.wait()`.
  • Loading branch information
ejortegau committed Jun 12, 2020
1 parent f63f7a6 commit 105cdc6
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions go/inst/instance_dao.go
Original file line number Diff line number Diff line change
Expand Up @@ -784,10 +784,6 @@ func ReadTopologyInstanceBufferable(instanceKey *InstanceKey, bufferWrites bool,
}

{
// wait for routines to finish before reading cluster attributes. This seems to be needed, as,
// otherwise, detecting whether a host is a replication group secondary to set up cluster attributes from its primary
// does not work. ToDo: Is there a better way to sync this?
waitGroup.Wait()
latency.Start("backend")
err = ReadInstanceClusterAttributes(instance)
latency.Stop("backend")
Expand Down

0 comments on commit 105cdc6

Please sign in to comment.