This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
fix bug : concurrency error is modified by other goroutines #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlomi-noach
approved these changes
Nov 11, 2019
shlomi-noach
reviewed
Dec 4, 2019
There was a problem hiding this comment.
I very much appreciate this PR, and it is good and correct. However, I prefer to use atomic.Error since this seems to be an already existing mechanism.
I'll draft an alternative PR.
|
Uhhhh... forget about that! My mistake. |
shlomi-noach
temporarily deployed
to
production/mysql_cluster=concertmaster
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1000
Concurrent bug in ReadTopologyInstanceBufferable