This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
Upstream issue 1042 #1043
Merged
Upstream issue 1042 #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closes #1042 |
Comment on lines
+51
to
+53
| "VerifyReplicationFilters": false, | ||
| "ReasonableMaintenanceReplicationLagSeconds": 20, | ||
| "CandidateInstanceExpireMinutes": 60, |
There was a problem hiding this comment.
these lines are duplicated?
There was a problem hiding this comment.
@EagleEyeJohn good catch. Would either you or @jfg956 be interested to submit a pull request to fix this?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #1042
This PR adds documentation for missing parameters (issues 1041).
This PR also does a little more than above issue to make things a little better: