Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Terminology changes #1182

Merged
merged 4 commits into from
Jun 5, 2020
Merged

Terminology changes #1182

merged 4 commits into from
Jun 5, 2020

Conversation

shlomi-noach
Copy link
Collaborator

When this project moved into GitHub, I spent some weeks changing terminology from slave to replica where possible. This included variable names, URL path, CLI params, and more. I kept slave terminology where:

  • there was strong correlation to a MySQL command (e.g. stop slave)
  • in some API responses where I didn't want to break usage.

This PR (WIP) pushes forward:

  • In web interface, use replica
  • In failure analysis, use Replica rather than Slave, e.g. DeadMasterAndSomeReplicas instead of DeadMasterAndSomeSlaves
    This breaks compatibility for people who rely on the specific analysis type (== text).

There are still a couple public API facing fields unchanged in this PR.

@shlomi-noach shlomi-noach merged commit a8f7bcb into master Jun 5, 2020
@shlomi-noach shlomi-noach deleted the more-terminology branch June 5, 2020 06:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant