Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Adjust the discovery uri logging to show the full dsn used (less pass… #1272

Merged
merged 2 commits into from
Nov 20, 2020

Conversation

sjmudd
Copy link
Collaborator

@sjmudd sjmudd commented Nov 19, 2020

Description

A few changes to show the full dsn used to talk to the MySQL driver. This helps debugging and what gets logged doesn't actually match what is passed to the driver which can be confusing.

Try to ensure that no passwords are logged, and if for some reason we can't match the dsn properly provide a synthetic dsn to provide information about the values we are using instead.

There are some tests to see that in various cases the process works correctly.

  • contributed code is using same conventions as original code
  • code is formatted via gofmt (please avoid goimports)
  • code passes compilation

sjmudd and others added 2 commits November 19, 2020 18:04
@shlomi-noach shlomi-noach merged commit 314e38d into openark:master Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants