This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
Add .PutKVPairs() method to KVStore interface #1274
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #1273
Description
This PR adds the
.PutKVPairs()
function to theKVStore
interface (fromgo/kv/kv.go
) to allow decisions around updating multiple KVs to be pushed down to the various KV store implementations. This new method replaces the single-KVPair method.PutKVPair()
fromgo/kv/kv.go
The following files were updated to use
.PutKVPairs()
vs single-KVPair updates:go/logic/command_applier.go
go/logic/orchestrator.go
go/logic/topology_recovery.go
For now the
.PutKVPairs()
function in eachKVStore
is just doing a plain-loop over.PutKeyValue()
. In the near-future this method will be used to implement atomic multi-KVPair updates for the Consul KV store (#1273) and potentially the Internal/ZooKeeper store, toocc @shlomi-noach