This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
Drop fixed list of cipher suites. #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch fixed the issue in our environment. |
kormat
force-pushed
the
ciphers
branch
2 times, most recently
from
0dc92ee
to
10063fd
Compare
The list of cipher suites hasn't been updated in 5 years, and the go docs since go1.12 say that it defaults to secure ciphers. Fixes openark#1294
shlomi-noach
reviewed
Mar 4, 2021
| @@ -46,8 +33,8 @@ func NewTLSConfig(caFile string, verifyCert bool) (*tls.Config, error) { | |||
|
|
|||
| // Set to TLS 1.2 as a minimum. This is overridden for mysql communication | |||
| c.MinVersion = tls.VersionTLS12 | |||
| // Remove insecure ciphers from the list | |||
| c.CipherSuites = cipherSuites | |||
| // "If CipherSuites is nil, a default list of secure cipher suites is used" | |||
There was a problem hiding this comment.
What is the default list of secure cipher suites?
There was a problem hiding this comment.
It's roughly https://golang.org/src/crypto/tls/cipher_suites.go?s=1340:1374#L40
(The ordering can vary depending on what hardware features are available)
shlomi-noach
approved these changes
Mar 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of cipher suites hasn't been updated in 5 years, and the go
docs since go1.12 say that it defaults to secure ciphers.
Fixes #1294