This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
Introducing HTTPAdvertise config #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #422
The optional
HTTPAdvertiseconfiguration variable specifies the advertised HTTP location for the service.At this time this is used in conjunction with raft reverse proxy.
When given,
HTTPAdvertisemust be of the formscheme://hostname:port, such ashttp://1.2.3.4:3030. When given,rafttrusts and assumes this URL does indeed point back to the leader.When not given,
orchestratorwill auto-compute HTTP reverse proxy URL, as before.HTTPAdvertiseis in particular useful when the orchestrator node is behind NAT or firewall which reroutes the port or changes the scheme.cc @enisoc