Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

fix executed_gtid_set missing from instances without binlogs #804

Merged
merged 1 commit into from
Feb 13, 2019

Conversation

fuyar
Copy link

@fuyar fuyar commented Feb 12, 2019

Fixes #803

Executed_Gtid_Set should be fetched for any MySQL instance and should not be restricted for "masters" (with binlog ON).

Copy link
Collaborator

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you! I'll send to testing and then merge.

@shlomi-noach shlomi-noach temporarily deployed to production/mysql_cluster=concertmaster February 13, 2019 05:14 Inactive
@shlomi-noach
Copy link
Collaborator

This works correctly.
The downside is that we waste network traffic: show master status returns Executed_Gtid_Set anyway, and we ignore it where we do have binary logs. Executed_Gtid_Set may be a large (long) value for clusters suffering from multiple failovers.

Still, this is more correct to use. I'll merge it as-is, and consider a future optimization that only reads @@global.gtid_executed if no binary logs are available.

@shlomi-noach shlomi-noach merged commit 36f055a into openark:master Feb 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants