Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Update support for go 1.12 (also triggers some file reformatting) #861

Merged
merged 10 commits into from
Jun 24, 2019

Conversation

sjmudd
Copy link
Collaborator

@sjmudd sjmudd commented Apr 11, 2019

Orchestrator build fails on go1.12 so adjust.

[user@host ~/src/orchestrator/src/github.com/github/orchestrator]$ go version
go version go1.12 darwin/amd64
[user@host ~/src/orchestrator/src/github.com/github/orchestrator]$ ./build.sh -b
Build only; no packaging
go version must be between 1.8 and 1.10

This also triggers some file reformatting (due to go fmt changes) which I've included.
There are no functional changes in the code.

  • contributed code is using same conventions as original code
  • code is formatted via gofmt (please avoid goimports)
  • code is built via ./build.sh

@sjmudd
Copy link
Collaborator Author

sjmudd commented Apr 11, 2019

Related: #857.

Copy link
Collaborator

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sjmudd thank you. Can you please also remove go1.8, and update the .travis.yml file?

@shlomi-noach
Copy link
Collaborator

Because go1.12 has different formatting than previous versions, go1.12 will be the minimal supported version. I don't wish to support both 1.11 and 1.12 with differing formatting.

@shlomi-noach shlomi-noach temporarily deployed to production/mysql_cluster=concertmaster June 23, 2019 11:46 Inactive
@shlomi-noach shlomi-noach temporarily deployed to production/mysql_cluster=conductor June 23, 2019 11:46 Inactive
@shlomi-noach
Copy link
Collaborator

shlomi-noach commented Jun 23, 2019

Added:

  • using go1.12 on Travis
  • using go1.12 in Docker
  • Updated script/ensure-go-installed

@shlomi-noach shlomi-noach merged commit 19c0209 into openark:master Jun 24, 2019
@sjmudd sjmudd deleted the sjmudd/go-1.12-support branch December 25, 2021 20:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants