This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
Fixing raft leaderAPI URL when URLPrefix nonempty #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlomi-noach
had a problem deploying
to
production/mysql_cluster=concertmaster
shlomi-noach
had a problem deploying
to
production/mysql_cluster=concertmaster
shlomi-noach
temporarily deployed
to
production/mysql_cluster=concertmaster
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #950 (comment)
When
URLPrefixis non-empty, theraftleaderAPIURL is malformed, as inhttp://127.0.0.1:3000//myprefix/api(note the double slash in//myprefix).This PR fixes that so that the URL is
http://127.0.0.1:3000/myprefix/api.When
URLPrefixis empty, nothing changes and the URL is already correct.cc @xjxyxgq