Skip to content

Commit

Permalink
ALSA: line6: Remove double line6_pcm_release() after failed acquire.
Browse files Browse the repository at this point in the history
commit 7e4379e upstream.

If there's an error, pcm is released in line6_pcm_acquire already.

Fixes: 247d95e ('ALSA: line6: Handle error from line6_pcm_acquire()')
Reviewed-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Andrej Krutak <dev@andree.sk>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
andree182 authored and gregkh committed Sep 7, 2016
1 parent 04790a5 commit c869384
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion sound/usb/line6/pcm.c
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ static int snd_line6_impulse_volume_put(struct snd_kcontrol *kcontrol,
err = line6_pcm_acquire(line6pcm, LINE6_STREAM_IMPULSE);
if (err < 0) {
line6pcm->impulse_volume = 0;
line6_pcm_release(line6pcm, LINE6_STREAM_IMPULSE);
return err;
}
} else {
Expand Down

0 comments on commit c869384

Please sign in to comment.