Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add retry logic on rpc calls, remove unnecessary deps, fix warnings #268

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wiseaidev
Copy link
Contributor

@wiseaidev wiseaidev commented Jun 3, 2024

I haven't tested these changes locally yet, but should work. Let's try it on CI. This PR contains the following changes:

@wiseaidev wiseaidev changed the title feat: add retry logic on rpc calls, remove unnecessary deps, fix warnings, upgrade to rust 1.75+ feat: add retry logic on rpc calls, remove unnecessary deps, fix warnings Jun 5, 2024
@mschneider
Copy link
Contributor

the retry mechanism is not reactive to error codes: a 429 can be retried, but all other errors should probably be exposed to the user immediately.
apart from that i would prefer if the retry was implemented outside the core client library functions, if users want to use their own logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants