Instantiate RSASignatureGenerator and RSASignatureValidator with in m… (CADC-12974) #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emory keys (byte arrays)
pdowler
requested changes
Dec 12, 2023
| @@ -150,86 +148,94 @@ public RsaSignatureGenerator(File keyFile) { | |||
| super(keyFile, true); | |||
| initPrivateKey(keyFile); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I think RsaSignatureGenerator needs a method like
public static KeyPair generateKeyPair(int len)
It's essentially the first half of the current generateKeyPair(File, File, int) method. The code in raven and vault can generate in-memory keys when necessary; cavern needs the existing File based method. I'm assuming byte correct byte[] is available via KeyPair methods (looks like it).
cadc-util/src/test/java/ca/nrc/cadc/util/RSASignatureGeneratorValidatorTest.java
Show resolved
Hide resolved
pdowler
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…emory keys (byte arrays)