Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small backward-compatible correction for latest Checkstyle #248

Closed
wants to merge 2 commits into from
Closed

Small backward-compatible correction for latest Checkstyle #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d35e1db
Small backward-compatible correction for latest Checkstyle
at88mph Jun 26, 2024
296373f
Update CheckStyle to remove old unsupported version.
at88mph Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cadc-quality/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@ sourceCompatibility = 1.8

group = 'org.opencadc'

version = '1.0'
version = '1.1'

description = 'OpenCADC Checkstyle Code Quality Rules'
def git_url = 'https://github.com/opencadc/core'

checkstyle {
ignoreFailures = false
configFile = file("${projectDir}/src/main/resources/cadc_checkstyle.xml")
toolVersion = '8.2'
toolVersion = '10.12.4'
sourceSets = [project.sourceSets.test]
}

8 changes: 4 additions & 4 deletions cadc-quality/src/main/resources/cadc_checkstyle.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@
<module name="FileTabCharacter">
<property name="eachLine" value="true"/>
</module>
<module name="LineLength">
<property name="max" value="160"/> <!--cadc changed from 100 -->
<property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
</module>

<module name="TreeWalker">
<module name="OuterTypeFilename"/>
Expand All @@ -46,10 +50,6 @@
<property name="allowByTailComment" value="true"/>
<property name="allowNonPrintableEscapes" value="true"/>
</module>
<module name="LineLength">
<property name="max" value="160"/> <!--cadc changed from 100 -->
<property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
</module>
<module name="AvoidStarImport"/>
<module name="OneTopLevelClass"/>
<module name="NoLineWrap"/>
Expand Down
Loading