Update RNG seed initialization in PARPACK #437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not completely comfortable with this and I'll try to get back to you later. One (not the only) concern here is whether the process ID can have large values, causing a long initial iteration. |
|
is there a way to test this? thanks |
|
no activity for a while, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following-up and trying to wrap-up #431. Taking into account the elements raised by #431 (comment) using basic tools.
Does this change seems appropriate to you @szhorvat @fghoussen ?
Each seed is initialized from a random generator coming from a master seed by running
myidtimes the RNG. For a given seed, successive call to the generator should produce an independent sequence according the info, then converting those number to fit within the LAPACK seed constraints.