-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit expense dialog #10875
Open
gustavlrsn
wants to merge
12
commits into
main
Choose a base branch
from
feat/edit-expense
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Edit expense dialog #10875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
… for new expense flow
gustavlrsn
force-pushed
the
feat/edit-expense
branch
from
December 19, 2024 12:40
4d8cc7c
to
8af437f
Compare
gustavlrsn
force-pushed
the
feat/edit-expense
branch
from
December 19, 2024 12:44
2fad1f8
to
6ed4f28
Compare
gustavlrsn
force-pushed
the
feat/edit-expense
branch
from
December 19, 2024 12:54
e7eb035
to
8e3cceb
Compare
gustavlrsn
force-pushed
the
feat/edit-expense
branch
from
December 19, 2024 13:01
8e3cceb
to
dbe8a55
Compare
gustavlrsn
force-pushed
the
feat/edit-expense
branch
from
December 19, 2024 13:52
1a20836
to
7e68b47
Compare
hdiniz
reviewed
Dec 19, 2024
url: !startOptions.current.duplicateExpense ? ei.url : null, | ||
attachment: ei.url, | ||
url: ei.url, // !startOptions.current.duplicateExpense ? ei.url : null, | ||
// url: !startOptions.current.duplicateExpense ? ei.url : null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may result in users submitting duplicated expenses with the same attachments urls, I think we should require a new upload for a new expense.
hdiniz
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For opencollective/opencollective#7683
Description
Inline edit expense flow (bundled together with the new expense submission flow preview feature flag).
Does not include editing the expense type (will show a button to go to the legacy edit flow).
Followups
Screenshots