Skip to content

Commit

Permalink
Change the default value for chunk count
Browse files Browse the repository at this point in the history
Signed-off-by: Ze Gan <ganze718@gmail.com>
  • Loading branch information
Pterosaur committed Dec 6, 2024
1 parent 824e657 commit e78949d
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 18 deletions.
20 changes: 10 additions & 10 deletions doc/TAM/SAI-Proposal-TAM-stream-telemetry.md
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ typedef enum _sai_switch_attr_t
{
// ...

/**
/**
* @brief Tam telemetry reporting byte size of chunk
*
* Defines the maximum number of bytes in a single report.
Expand All @@ -460,22 +460,21 @@ typedef enum _sai_switch_attr_t
* Because we don't expect the IPFIX record to be fragmented.
*
* @type sai_uint32_t
* @flags CREATE_AND_SET
* @flags CREATE_ONLY
* @default 65535
*/
SAI_SWITCH_ATTR_TAM_REPORT_CHUNK_SIZE,

/**
* @brief Tam telemetry chunk count
*
* This value indicates how many chunks of reports that can be restored in the buffer.
* If the data structure is a ring buffer, the byte size of ring buffer is chunk count * chunk size.
* 1 means that there is only one chunk of report in the buffer.
* The default value, 0, means that this value was determined by the vendor.
* If the buffer is full, new incoming data will be dropped.
*
* @type sai_uint32_t
* @flags CREATE_ONLY
* @default 1
* @default 0
*/
SAI_SWITCH_ATTR_TAM_CHUNK_COUNT,

Expand Down Expand Up @@ -732,7 +731,8 @@ typedef enum _sai_tam_tel_type_attr_t
* @brief The mode of TAM telemetry type
*
* @type sai_tam_tel_type_mode_t
* @flags MANDATORY_ON_CREATE | CREATE_ONLY
* @flags CREATE_ONLY
* @default SAI_TAM_TEL_TYPE_MODE_SINGLE_TYPE
*/
SAI_TAM_TEL_TYPE_ATTR_MODE,

Expand Down Expand Up @@ -989,14 +989,14 @@ typedef struct _sai_stat_st_capability_list_t
typedef enum _sai_tam_tel_type_mode_t
{
/**
* @brief This TAM telemetry type supports to bound multiple counter types
* @brief This TAM telemetry type supports to bound only one counter type
*/
SAI_TAM_TEL_TYPE_MODE_MIXED_TYPE,
SAI_TAM_TEL_TYPE_MODE_SINGLE_TYPE,

/**
* @brief This TAM telemetry type supports to bound only one counter type
* @brief This TAM telemetry type supports to bound multiple counter types
*/
SAI_TAM_TEL_TYPE_MODE_SINGLE_TYPE,
SAI_TAM_TEL_TYPE_MODE_MIXED_TYPE,

} sai_tam_tel_type_mode_t;

Expand Down
6 changes: 3 additions & 3 deletions inc/saiswitch.h
Original file line number Diff line number Diff line change
Expand Up @@ -3094,7 +3094,7 @@ typedef enum _sai_switch_attr_t
* Because we don't expect the IPFIX record to be fragmented.
*
* @type sai_uint32_t
* @flags CREATE_AND_SET
* @flags CREATE_ONLY
* @default 65535
*/
SAI_SWITCH_ATTR_TAM_REPORT_CHUNK_SIZE,
Expand All @@ -3104,12 +3104,12 @@ typedef enum _sai_switch_attr_t
*
* This value indicates how many chunks of reports that can be restored in the buffer.
* If the data structure is a ring buffer, the byte size of ring buffer is chunk count * chunk size.
* 1 means that there is only one chunk of report in the buffer.
* The default value, 0, means that this value was determined by the vendor.
* If the buffer is full, new incoming data will be dropped.
*
* @type sai_uint32_t
* @flags CREATE_ONLY
* @default 1
* @default 0
*/
SAI_SWITCH_ATTR_TAM_CHUNK_COUNT,

Expand Down
11 changes: 6 additions & 5 deletions inc/saitam.h
Original file line number Diff line number Diff line change
Expand Up @@ -913,14 +913,14 @@ typedef enum _sai_tam_telemetry_type_t
typedef enum _sai_tam_tel_type_mode_t
{
/**
* @brief This TAM telemetry type supports to bound multiple counter types
* @brief This TAM telemetry type supports to bound only one counter type
*/
SAI_TAM_TEL_TYPE_MODE_MIXED_TYPE,
SAI_TAM_TEL_TYPE_MODE_SINGLE_TYPE,

/**
* @brief This TAM telemetry type supports to bound only one counter type
* @brief This TAM telemetry type supports to bound multiple counter types
*/
SAI_TAM_TEL_TYPE_MODE_SINGLE_TYPE,
SAI_TAM_TEL_TYPE_MODE_MIXED_TYPE,

} sai_tam_tel_type_mode_t;

Expand Down Expand Up @@ -1125,7 +1125,8 @@ typedef enum _sai_tam_tel_type_attr_t
* @brief The mode of TAM telemetry type
*
* @type sai_tam_tel_type_mode_t
* @flags MANDATORY_ON_CREATE | CREATE_ONLY
* @flags CREATE_ONLY
* @default SAI_TAM_TEL_TYPE_MODE_SINGLE_TYPE
*/
SAI_TAM_TEL_TYPE_ATTR_MODE,

Expand Down

0 comments on commit e78949d

Please sign in to comment.