Query: Shared threshold mode for the buffer profile

[JaiOCP]

SAI_BUFFER_PROFILE_ATTR_THRESHOLD_MODE is mandatory and will always override SAI_BUFFER_POOL_ATTR_THRESHOLD_MODE.

What is the need of SAI_BUFFER_POOL_ATTR_THRESHOLD_MODE?

/**
 * @brief Shared threshold mode for the buffer profile
 *
 * If set, this overrides #SAI_BUFFER_POOL_ATTR_THRESHOLD_MODE.
 *
 * @type sai_buffer_profile_threshold_mode_t
 * @flags MANDATORY_ON_CREATE | CREATE_ONLY
 */
SAI_BUFFER_PROFILE_ATTR_THRESHOLD_MODE,

[kcudnik]

Probably this is a mistake in comment

[JaiOCP]

It's more than that. SAI_BUFFER_PROFILE_ATTR_THRESHOLD_MODE effectively deprecates SAI_BUFFER_POOL_ATTR_THRESHOLD_MODE, given that it is mandatory and create only.

…

On Thu, Nov 2, 2023 at 10:29 AM Kamil Cudnik ***@***.***> wrote: Probably this is a mistake in comment — Reply to this email directly, view it on GitHub <#1919 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKCSHLNT2JKPRFQXJ2ICKNDYCPKAPAVCNFSM6AAAAAA63EW7NGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJRGIYTAOBWGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- This electronic communication and the information and any files transmitted with it, or attached to it, are confidential and are intended solely for the use of the individual or entity to whom it is addressed and may contain information that is confidential, legally privileged, protected by privacy laws, or otherwise restricted from disclosure to anyone else. If you are not the intended recipient or the person responsible for delivering the e-mail to the intended recipient, you are hereby notified that any use, copying, distributing, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited. If you received this e-mail in error, please return the e-mail to the sender, delete it from your computer, and destroy any printed copy of it.

[AshokDaparthi]

As i remember initial proposal SAI_BUFFER_PROFILE_ATTR_THRESHOLD_MODE is optional. if profile is not created without this, it should inherit from pool. if this is mandatory now, then there is no need of SAI_BUFFER_POOL_ATTR_THRESHOLD_MODE.

[JaiOCP]

Hi Ashok, Given SAI_BUFFER_POOL_ATTR_THRESHOLD_MODE is mandatory, SAI_BUFFER_PROFILE_ATTR_THRESHOLD_MODE is a noop now. This is what I see based on the flags. Regards, -Jai

…

On Thu, Nov 2, 2023 at 7:59 PM Ashok Daparthi-Dell ***@***.***> wrote: As i remember initial proposal SAI_BUFFER_PROFILE_ATTR_THRESHOLD_MODE is optional. if profile is not created without this, it should inherit from pool. if this is mandatory now, then there is no need of SAI_BUFFER_POOL_ATTR_THRESHOLD_MODE. — Reply to this email directly, view it on GitHub <#1919 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKCSHLPHKRRURKUPOYP4MWDYCRMXHAVCNFSM6AAAAAA63EW7NGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJRHAZTOMJUGI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- This electronic communication and the information and any files transmitted with it, or attached to it, are confidential and are intended solely for the use of the individual or entity to whom it is addressed and may contain information that is confidential, legally privileged, protected by privacy laws, or otherwise restricted from disclosure to anyone else. If you are not the intended recipient or the person responsible for delivering the e-mail to the intended recipient, you are hereby notified that any use, copying, distributing, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited. If you received this e-mail in error, please return the e-mail to the sender, delete it from your computer, and destroy any printed copy of it.

[kcudnik]

Please bring that topic on Thursday sai meeting + @rlhui and we discuss whether mark this as deprecated