Addition of platform information file path name to sai_switch_initiai… #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lize Addition of below RO attributes and define keys to enable its configuration via KV pair: SAI_SWITCH_ATTR_LAG_MEMBERS SAI_SWITCH_ATTR_LAG_NUMBER SAI_SWITCH_ATTR_ECMP_PATHS SAI_SWITCH_ATTR_L3_NEIGHBOR_TABLE_SIZE SAI_SWITCH_ATTR_L3_ROUTE_TABLE_SIZE SAI_SWITCH_ATTR_NUM_UNICAST_QUEUES SAI_SWITCH_ATTR_NUM_MULTICAST_QUEUES SAI_SWITCH_ATTR_NUM_QUEUES SAI_SWITCH_ATTR_NUM_CPU_QUEUES SAI_SWITCH_ATTR_NUM_ECMP_GROUPS Added Macro SAI_SWITCH_ATTR_RESET_DEFAULT to configure above attributes to NPU default when set with this value changed uin32_t to sai_uint32_t Changes to be committed: modified: inc/saiswitch.h modified: inc/saitypes.h
Changes to be committed: modified: inc/saiswitch.h modified: inc/saitypes.h
| @@ -483,6 +534,7 @@ typedef sai_status_t (*sai_initialize_switch_fn)( | |||
| _In_ sai_switch_profile_id_t profile_id, | |||
| _In_reads_z_(SAI_MAX_HARDWARE_ID_LEN) char* switch_hardware_id, | |||
| _In_reads_opt_z_(SAI_MAX_FIRMWARE_PATH_NAME_LEN) char* firmware_path_name, | |||
| _In_reads_opt_z_(SAI_MAX_PLATFORM_INFO_PATH_NAME_LEN) char* platform_info_path_name, | |||
There was a problem hiding this comment.
not sure what this is used for, can you explain?
There was a problem hiding this comment.
Platform specific file will contain NPU related information like:
Pre-emphasis setting,
Lane mapping and Polarity,
LED configuration,
Break-out modes etc.
There was a problem hiding this comment.
instead of add a parameter to the init_switch_fn, can we use a K/V to provide the platform specifi file, e.g., INIT_CONFIG_FILE=platform_info_file?
There was a problem hiding this comment.
Yes Guohan, added a key (INIT_CONFIG_FILE) and removed the parameter from switch init function.
… file path and removed the parameter from sai switch init routine Changes to be committed: modified: inc/saiswitch.h
|
merged, thanks |
IGordynskyi
pushed a commit
to IGordynskyi/SAI
that referenced
this pull request
Sep 23, 2016
RyoYang
pushed a commit
to RyoYang/SAI
that referenced
this pull request
May 26, 2022
Add two T0 configurations, metadata and port (without serdes) base on the config_db.json configuration file. Define the new setup method in T0 broadcom. Add a config file for the s6000_s1220_r0 Refactor the method for abstract the info from config.ini, make the key from the name to the index, which can map the the port index directly. Todo: Add the serdes config, which needs to read the config file and parse the info. Test done: Tested on the dut.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of platform information file path name to sai_switch_initiailize
Addition of below RO attributes and define keys to enable its configuration via
KV pair:
SAI_SWITCH_ATTR_LAG_MEMBERS
SAI_SWITCH_ATTR_LAG_NUMBER
SAI_SWITCH_ATTR_ECMP_PATHS
SAI_SWITCH_ATTR_L3_NEIGHBOR_TABLE_SIZE
SAI_SWITCH_ATTR_L3_ROUTE_TABLE_SIZE
SAI_SWITCH_ATTR_NUM_UNICAST_QUEUES
SAI_SWITCH_ATTR_NUM_MULTICAST_QUEUES
SAI_SWITCH_ATTR_NUM_QUEUES
SAI_SWITCH_ATTR_NUM_CPU_QUEUES
SAI_SWITCH_ATTR_NUM_ECMP_GROUPS
Added Macro SAI_SWITCH_ATTR_RESET_DEFAULT to configure above attributes to NPU
default when set with this value
changed uin32_t to sai_uint32_t
Changes to be committed:
modified: inc/saiswitch.h
modified: inc/saitypes.h