Class-Based Forwarding #1193

j-bos · 2021-02-18T15:25:55Z

This PR defines class-based forwarding. It contains two aspects:

Assignment of a Forwarding Class to a packet, via QOS map or ACL
New next-hop group type: SAI_NEXT_HOP_GROUP_TYPE_CLASS_BASED

Where member selection is based on the forwarding-class of the packet.

Signed-off-by: j-bos jbos@cisco.com

rlhui · 2021-02-18T16:54:10Z

@JaiOCP , @marian-pritsak , @ashutosh-agrawal - would you like to review/sign-off this? Thanks.

rlhui · 2021-02-18T16:56:55Z

@j-bos - thanks. possible to also upload the ppt to https://github.com/opencomputeproject/SAI/tree/master/doc/ECMP?

rlhui · 2021-02-18T16:58:06Z

@j-bos - please check the DCO error if this can be resolved.

inc/saiqosmap.h

rck-innovium · 2021-02-19T12:55:56Z

Since we do not have an explicit capability check, can you spell out the mechanism to know whether a SAI implementation supports this capability. Say, if SAI_SWITCH_ATTR_MAX_NUMBER_OF_FORWARDING_CLASSES is 0?

JaiOCP

We need to enhance the SAI behavioral model to accommodate this change.

Concept of Internal Class as an index in ECMP Group need to come from ACL table.
Today Next Hop Group block has a match only on next hop group hash value. This need to be explicitly enhanced to include class id.

JaiOCP

Raising this question to capture in review.

Given the concept of class id based ECMP group indexing is a specific implementation to silicon and is not RFC based: Should it be not part of SAI extensions?

j-bos · 2021-02-23T20:26:42Z

Since we do not have an explicit capability check, can you spell out the mechanism to know whether a SAI implementation supports this capability. Say, if SAI_SWITCH_ATTR_MAX_NUMBER_OF_FORWARDING_CLASSES is 0?

The most direct would be an enum-capability for next-hop group type (class-based). Though, I think a check if SAI_SWITCH_ATTR_MAX_NUMBER_OF_FORWARDING_CLASSES is supported and non-zero would be reasonable as well.

rlhui · 2021-03-10T06:49:46Z

@lguohan - would you like to review? Thanks.

inc/sainexthopgroup.h

inc/saiqosmap.h

inc/saiswitch.h

rlhui · 2021-04-28T05:37:45Z

@marian-pritsak , please also help review, thanks.

j-bos · 2021-07-06T04:24:21Z

@j-bos - please check the DCO error if this can be resolved.

Resolved

kcudnik · 2021-07-06T07:47:20Z

please resolve conflicts

Signed-off-by: Jason Bos <jbos@cisco.com>

inc/saiport.h

Signed-off-by: Jason Bos <jbos@cisco.com>

doc/ECMP/Class-Based-Forwarding.md

abdosi · 2021-08-04T18:37:00Z

@j-bos Are you working on update using new object ?

Signed-off-by: Jason Bos <jbos@cisco.com>

inc/sainexthopgroup.h

inc/saiswitch.h

inc/saiport.h

JaiOCP

Please update the pipeline with CBF and ECMP stage indicated as optional.

kcudnik · 2021-08-26T16:29:12Z

/azp run

azure-pipelines · 2021-08-26T16:29:16Z

Pull request contains merge conflicts.

kcudnik · 2021-08-26T17:04:10Z

please resolve conflicts

Signed-off-by: Jason Bos <jbos@cisco.com>

…YPE_MAX to change Signed-off-by: Jason Bos <jbos@cisco.com>

meta/checkheaders.pl

inc/saiacl.h

Adjust to provide a representation of optional steps in the behavioral model diagram. Dashed border by itself was hard to see, so used a hash-fill as well. Signed-off-by: Jason Bos <jbos@cisco.com>

Signed-off-by: Jason Bos <jbos@cisco.com>

j-bos · 2021-08-26T19:35:51Z

Please update the pipeline with CBF and ECMP stage indicated as optional.

Done

This check will make sure that enum values are constant from this point on all future commits. [meta] Add enum ancestry check on SAI includes (opencomputeproject#1297) Will make sure that from BEGIN_COMMIT we will be always backward compatible for SAI enums Class-Based Forwarding (opencomputeproject#1193) This PR defines class-based forwarding. It contains two aspects: Assignment of a Forwarding Class to a packet, via QOS map or ACL New next-hop group type: SAI_NEXT_HOP_GROUP_TYPE_CLASS_BASED Where member selection is based on the forwarding-class of the packet. Signed-off-by: Jason Bos <jbos@cisco.com> [tests] Add missing lib -lzmq to saithrift (opencomputeproject#1298) [meta] Make sure SAI version components are unsigned integers (opencomputeproject#1300) [meta] Add lower case notification names (opencomputeproject#1301)

This PR defines class-based forwarding. It contains two aspects: Assignment of a Forwarding Class to a packet, via QOS map or ACL New next-hop group type: SAI_NEXT_HOP_GROUP_TYPE_CLASS_BASED Where member selection is based on the forwarding-class of the packet. Signed-off-by: Jason Bos <jbos@cisco.com>

rck-innovium suggested changes Feb 19, 2021

View reviewed changes

inc/saiqosmap.h Show resolved Hide resolved

JaiOCP reviewed Feb 23, 2021

View reviewed changes

TACappleman reviewed Mar 15, 2021

View reviewed changes

inc/sainexthopgroup.h Show resolved Hide resolved

TACappleman reviewed Mar 15, 2021

View reviewed changes

inc/saiqosmap.h Show resolved Hide resolved

j-bos marked this pull request as ready for review March 24, 2021 07:11

JaiOCP reviewed Apr 15, 2021

View reviewed changes

inc/saiswitch.h Show resolved Hide resolved

j-bos closed this Jul 6, 2021

j-bos reopened this Jul 6, 2021

j-bos added 4 commits July 19, 2021 22:53

Class-Based Forwarding

fb7ea4d

Signed-off-by: Jason Bos <jbos@cisco.com>

Create Class-Based-Forwarding.md

85db8bc

Signed-off-by: Jason Bos <jbos@cisco.com>

Fix for comment formatting

c043c39

Signed-off-by: Jason Bos <jbos@cisco.com>

Add Behavior Model diagram

1d822c8

Signed-off-by: Jason Bos <jbos@cisco.com>

kcudnik reviewed Jul 20, 2021

View reviewed changes

inc/saiport.h Show resolved Hide resolved

Fix attribute ordering after merge

e8d3c10

Signed-off-by: Jason Bos <jbos@cisco.com>

j-bos commented Jul 22, 2021

View reviewed changes

doc/ECMP/Class-Based-Forwarding.md Show resolved Hide resolved

j-bos commented Jul 22, 2021

View reviewed changes

doc/ECMP/Class-Based-Forwarding.md Show resolved Hide resolved

j-bos added 3 commits August 10, 2021 07:17

Changes towards new object for fc to index map

d7983c1

Signed-off-by: Jason Bos <jbos@cisco.com>

More changes towards new object for fc to index map

9075a31

Signed-off-by: Jason Bos <jbos@cisco.com>

Merge remote-tracking branch 'upstream/master'

e163778

Signed-off-by: Jason Bos <jbos@cisco.com>

j-bos and others added 4 commits August 19, 2021 08:08

minor documentation update

0efff48

Signed-off-by: Jason Bos <jbos@cisco.com>

Update pipeline_v9.vsdx

c6eb5df

Signed-off-by: Jason Bos <jbos@cisco.com>

Merge branch 'master' into master

46120df

small merge fixup

d9bc49c

Signed-off-by: Jason Bos <jbos@cisco.com>

abanu-ms approved these changes Aug 20, 2021

View reviewed changes

abanu-ms suggested changes Aug 23, 2021

View reviewed changes

inc/sainexthopgroup.h Show resolved Hide resolved

kperumalbfn reviewed Aug 24, 2021

View reviewed changes

inc/saiswitch.h Show resolved Hide resolved

inc/saiport.h Show resolved Hide resolved

ashutosh-agrawal approved these changes Aug 26, 2021

View reviewed changes

kperumalbfn approved these changes Aug 26, 2021

View reviewed changes

JaiOCP approved these changes Aug 26, 2021

View reviewed changes

rck-innovium approved these changes Aug 26, 2021

View reviewed changes

j-bos added 3 commits August 26, 2021 10:52

Merge remote-tracking branch 'upstream/master'

4ee95c9

revert meta change which is no longer needed

0b5e37c

Signed-off-by: Jason Bos <jbos@cisco.com>

fix the recently-introduced enum value checking to allow SAI_OBJECT_T…

931ed05

…YPE_MAX to change Signed-off-by: Jason Bos <jbos@cisco.com>

j-bos commented Aug 26, 2021

View reviewed changes

meta/checkheaders.pl Show resolved Hide resolved

abanu-ms approved these changes Aug 26, 2021

View reviewed changes

kcudnik reviewed Aug 26, 2021

View reviewed changes

inc/saiacl.h Show resolved Hide resolved

j-bos added 2 commits August 26, 2021 12:29

Update pipeline_v9.vsdx

632d265

Adjust to provide a representation of optional steps in the behavioral model diagram. Dashed border by itself was hard to see, so used a hash-fill as well. Signed-off-by: Jason Bos <jbos@cisco.com>

Add SAI_API_MAX to meta check skipping

b11e57c

Signed-off-by: Jason Bos <jbos@cisco.com>

kcudnik approved these changes Aug 26, 2021

View reviewed changes

abanu-ms mentioned this pull request Aug 27, 2021

[cbf] Add Class Based Forwarding support sonic-net/sonic-sairedis#909

Merged

rlhui merged commit 725cd53 into opencomputeproject:master Aug 27, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Class-Based Forwarding #1193

Class-Based Forwarding #1193

j-bos commented Feb 18, 2021 •

edited

Loading

rlhui commented Feb 18, 2021

rlhui commented Feb 18, 2021

rlhui commented Feb 18, 2021

rck-innovium commented Feb 19, 2021

JaiOCP left a comment •

edited

Loading

JaiOCP left a comment

j-bos commented Feb 23, 2021 •

edited

Loading

rlhui commented Mar 10, 2021

rlhui commented Apr 28, 2021

j-bos commented Jul 6, 2021

kcudnik commented Jul 6, 2021

abdosi commented Aug 4, 2021

JaiOCP left a comment

kcudnik commented Aug 26, 2021

azure-pipelines bot commented Aug 26, 2021

kcudnik commented Aug 26, 2021

j-bos commented Aug 26, 2021

Class-Based Forwarding #1193

Class-Based Forwarding #1193

Conversation

j-bos commented Feb 18, 2021 • edited Loading

rlhui commented Feb 18, 2021

rlhui commented Feb 18, 2021

rlhui commented Feb 18, 2021

rck-innovium commented Feb 19, 2021

JaiOCP left a comment • edited Loading

Choose a reason for hiding this comment

JaiOCP left a comment

Choose a reason for hiding this comment

j-bos commented Feb 23, 2021 • edited Loading

rlhui commented Mar 10, 2021

rlhui commented Apr 28, 2021

j-bos commented Jul 6, 2021

kcudnik commented Jul 6, 2021

abdosi commented Aug 4, 2021

JaiOCP left a comment

Choose a reason for hiding this comment

kcudnik commented Aug 26, 2021

azure-pipelines bot commented Aug 26, 2021

kcudnik commented Aug 26, 2021

j-bos commented Aug 26, 2021

j-bos commented Feb 18, 2021 •

edited

Loading

JaiOCP left a comment •

edited

Loading

j-bos commented Feb 23, 2021 •

edited

Loading