ISIS trap support for SAI #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rlhui - Could you please advise next steps on this PR. Maybe schedule in SAI community meeting. |
kcudnik
approved these changes
May 25, 2021
abdosi
reviewed
Jun 4, 2021
itaibaz
reviewed
Jun 7, 2021
itaibaz
approved these changes
Jun 15, 2021
itaibaz
reviewed
Jun 15, 2021
inc/saihostif.h
Outdated
| @@ -322,6 +322,14 @@ typedef enum _sai_hostif_trap_type_t | |||
| /** Default packet action is forward */ | |||
| SAI_HOSTIF_TRAP_TYPE_IPV6_NEIGHBOR_ADVERTISEMENT = 0x00002013, | |||
|
|
|||
| /** | |||
| * @brief Intermediate System-to-Intermediate System (IS-IS) protocol | |||
| * traffic: L1: 01:80:c2:00:00:15, L2: 01:80:c2:00:00:15 | |||
There was a problem hiding this comment.
L1 mac should probably be :14 and not :15
itaibaz
approved these changes
Jun 16, 2021
|
could the DCO be fixed? |
Sure, Done. |
Hi, it still shows DCO not yet passed? Thanks. |
kcudnik
reviewed
Jun 30, 2021
Signed-off-by: Venkat Garigipati <venkatg@cisco.com>
Signed-off-by: Venkat Garigipati <venkatg@cisco.com>
Signed-off-by: Venkat Garigipati <venkatg@cisco.com>
Signed-off-by: Venkat Garigipati <venkatg@cisco.com>
Signed-off-by: Venkat Garigipati <venkatg@cisco.com>
SAI_HOSTIF_TRAP_TYPE_ISIS. Signed-off-by: Venkat Garigipati <venkatg@cisco.com>
Signed-off-by: Venkat Garigipati <venkatg@cisco.com>
VenkatCisco
force-pushed
the
VenkatCisco/ISIS
branch
from
3733bc1 to
84a8bce
Compare
Signed-off-by: Venkat Garigipati <venkatg@cisco.com>
VenkatCisco
force-pushed
the
VenkatCisco/ISIS
branch
from
e3b275d to
a70c039
Compare
kcudnik
approved these changes
Jul 1, 2021
Signed-off-by: Venkat Garigipati <venkatg@cisco.com>
tomzhu1
pushed a commit
to Metaswitch/SAI
that referenced
this pull request
Jul 20, 2021
* Extends SAI-v1.8 capabilities to support new ISIS header SAI_HOSTIF_TRAP_TYPE_ISIS. Signed-off-by: Venkat Garigipati <venkatg@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Venkat Garigipati venkatg@cisco.com
Extends SAI-v1.8 capabilities to support new ISIS header SAI_HOSTIF_TRAP_TYPE_ISIS.