Add label attribute for counter #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Midhun Somasundaran <msomasundaran@fb.com>
lguohan
approved these changes
Feb 10, 2022
kperumalbfn
approved these changes
Feb 10, 2022
kcudnik
approved these changes
Feb 15, 2022
tushar-ty
approved these changes
Feb 18, 2022
|
Counter does not have any mandatory attribute to identify object uniquely. Adding a label attribute that can be used to uniquely identify object during warmboot scenarios. This is similar to existing label attribute used by LAG and virtual router. Related to: Signed-off-by: Midhun Somasundaran msomasundaran@fb.com |
shri-khare
added a commit
to shri-khare/SAI
that referenced
this pull request
Mar 6, 2022
Summary: This is similar to opencomputeproject#1158 and opencomputeproject#1407. Those PRs added label attribute for LAG/virtual router and counter. This PR adds similar label attribute for ACL counter. ACL counter does not have any mandatory attribute to identify object uniquely. Adding a label attribute that can be used to uniquely identify ACL counter object during warmboot. The attribute is considered as user data attached to the object. Signed-off-by: Shrikrishna Khare <skhare@fb.com>
rlhui
pushed a commit
that referenced
this pull request
Mar 13, 2022
Summary: This is similar to #1158 and #1407. Those PRs added label attribute for LAG/virtual router and counter. This PR adds similar label attribute for ACL counter. ACL counter does not have any mandatory attribute to identify object uniquely. Adding a label attribute that can be used to uniquely identify ACL counter object during warmboot. The attribute is considered as user data attached to the object. Signed-off-by: Shrikrishna Khare <skhare@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Counter does not have any mandatory attribute to identify object uniquely. Adding a label attribute that can be used to uniquely identify object during warmboot scenarios. This is similar to existing label attribute used by LAG and virtual router.
The attribute is considered as user data attached to the object.
Related to:
#1158
Signed-off-by: Midhun Somasundaran msomasundaran@fb.com