Add switch api for clause 22 mdio access #1507

jiahua-wang · 2022-06-23T20:36:52Z

Signed-off-by: Jiahua Wang jiahua.wang@broadcom.com

    Why I did it
    There are 2 mdio access modes: clause 45 and clause 22. The existing sai
    switch api "switch_mdio_read/switch_mdio_write" does not distinguish the
    2 modes.

    How I did it
    The new sai switch api "switch_mdio_cl22_ead/switch_mdio_cl22_write" are
    added for clause 22 mdio access only.

    How to verify it
    On a platform with mdio clause 22 device connected to NPU mdio bus,
    PAI/gearbox will only work with the new new sai switch api when there is
    no other means to configure the mdio access mode.

Signed-off-by: Jiahua Wang <jiahua.wang@broadcom.com>

lguohan · 2022-06-23T20:55:52Z

inc/saiswitch.h

@@ -3272,6 +3272,8 @@ typedef struct _sai_switch_api_t
    sai_remove_switch_tunnel_fn            remove_switch_tunnel;
    sai_set_switch_tunnel_attribute_fn     set_switch_tunnel_attribute;
    sai_get_switch_tunnel_attribute_fn     get_switch_tunnel_attribute;
+    sai_switch_mdio_read_fn                switch_mdio_cl22_read;
+    sai_switch_mdio_write_fn               switch_mdio_cl22_write;


can you add comments on what is the difference bewteen the switch_mdio_read and switch_mdio_cl22_read? why need to add these new api?

MDIO access can be 2 types, clause 45 and clause 22. While most MDIO devices use clause 45, there are still some 1G or lower speed PHY devices use clause 22. The SAI switch api functions switch_mdio_read/switch_mdio_write are used for clause 45 mdio device access. The newly added SAI switch api functions switch_mdio_cl22_read/switch_mdio_cl22_write are used for clause 22 mdio device access.

can you add this to your commit message so that we can merge with proper commit message?

I have changed the commit message to:
Author: Jiahua Wang jiahua.wang@broadcom.com
Date: Mon Jul 25 10:31:10 2022 -0700

Merge branch 'switch_mdio_cl22' of https://github.com/jiahua-wang/SAI into switch_mdio_cl22

commit c47ee84
Author: Jiahua Wang jiahua.wang@broadcom.com
Date: Tue Jul 12 12:16:58 2022 -0700

Add sai_switch_mdio_cl22_read_fn and sai_switch_mdio_cl22_write_fn Signed-off-by: Jiahua Wang <jiahua.wang@broadcom.com> Why I did it There are 2 mdio access modes: clause 45 and clause 22. The existing sai switch api "switch_mdio_read/switch_mdio_write" does not distinguish the 2 modes. How I did it The new sai switch api "switch_mdio_cl22_ead/switch_mdio_cl22_write" are added for clause 22 mdio access only. How to verify it On a platform with mdio clause 22 device connected to NPU mdio bus, PAI/gearbox will only work with the new new sai switch api when there is no other means to configure the mdio access mode.

so the expectation is that switch_mdio_read/write will be used for clause 45 only, and switch_mdio_cl22_read/write will be used for clause 22?

switch_mdio_read/write will be used for clause 45 only with regular usage. But it can be used for clause 22 under other configuration/control, e.g. soc property/experimental attribute.

lguohan · 2022-06-23T20:56:12Z

also, can you check the build failure?

kcudnik · 2022-06-24T09:05:19Z

you will also need to refactor parse.pl to pass sanitycheck

Signed-off-by: Jiahua Wang <jiahua.wang@broadcom.com>

Signed-off-by: Jiahua Wang <jiahua.wang@broadcom.com> Why I did it There are 2 mdio access modes: clause 45 and clause 22. The existing sai switch api "switch_mdio_read/switch_mdio_write" does not distinguish the 2 modes. How I did it The new sai switch api "switch_mdio_cl22_ead/switch_mdio_cl22_write" are added for clause 22 mdio access only. How to verify it On a platform with mdio clause 22 device connected to NPU mdio bus, PAI/gearbox will only work with the new new sai switch api when there is no other means to configure the mdio access mode.

…into switch_mdio_cl22

jimmyzhai · 2022-08-02T10:57:06Z

inc/saiswitch.h

+ * @param[in] number_of_registers Number of consecutive registers to read
+ * @param[out] reg_val Register read values
+ */
+typedef sai_status_t (*sai_switch_mdio_cl22_read_fn)(


Type sai_switch_mdio_cl22_read_fn is same as sai_switch_mdio_read_fn. It looks not needed to define it.

In the first commit: 912c4c4 The new cl22 functions had the type you suggested. But it would not pass the parse.pl sanity check. I changed the cl22 function to the new type in the last commit: 0fb1c06

jimmyzhai · 2022-08-02T10:59:53Z

inc/saiswitch.h

@@ -3272,6 +3312,8 @@ typedef struct _sai_switch_api_t
    sai_remove_switch_tunnel_fn            remove_switch_tunnel;
    sai_set_switch_tunnel_attribute_fn     set_switch_tunnel_attribute;
    sai_get_switch_tunnel_attribute_fn     get_switch_tunnel_attribute;
+    sai_switch_mdio_cl22_read_fn           switch_mdio_cl22_read;
+    sai_switch_mdio_cl22_write_fn          switch_mdio_cl22_write;


It can be:

sai_switch_mdio_read_fn switch_mdio_cl22_read sai_switch_mdio_write_fn switch_mdio_cl22_write

In the first commit: 912c4c4 The new cl22 functions had the type you suggested. But it would not pass the parse.pl sanity check. I changed the cl22 function to the new type in the last commit: 0fb1c06

Add switch api for clause 22 mdio access

912c4c4

Signed-off-by: Jiahua Wang <jiahua.wang@broadcom.com>

jiahua-wang mentioned this pull request Jun 23, 2022

Add mdio access type (clause 45/clause 22) attribute #1493

Closed

lguohan reviewed Jun 23, 2022

View reviewed changes

jiahua-wang added 2 commits July 12, 2022 11:46

Add switch_mdio_cl22_read and switch_mdio_cl22_write to style.pm

f045ca9

Signed-off-by: Jiahua Wang <jiahua.wang@broadcom.com>

Add sai_switch_mdio_cl22_read_fn and sai_switch_mdio_cl22_write_fn

0acba90

Signed-off-by: Jiahua Wang <jiahua.wang@broadcom.com>

kcudnik approved these changes Jul 19, 2022

View reviewed changes

jiahua-wang added 2 commits July 25, 2022 10:15

Merge branch 'switch_mdio_cl22' of https://github.com/jiahua-wang/SAI …

0fb1c06

…into switch_mdio_cl22

jimmyzhai reviewed Aug 2, 2022

View reviewed changes

jiahua-wang mentioned this pull request Aug 3, 2022

SONiC NPU MDIO access support and gbsyncd docker enhancement HLD sonic-net/SONiC#1045

Merged

kcudnik approved these changes Sep 12, 2022

View reviewed changes

jimmyzhai approved these changes Oct 8, 2022

View reviewed changes

lguohan merged commit 1b268a8 into opencomputeproject:master Oct 10, 2022

rlhui mentioned this pull request Mar 13, 2023

SAI 1.11.0 Release Notes #1728

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add switch api for clause 22 mdio access #1507

Add switch api for clause 22 mdio access #1507

jiahua-wang commented Jun 23, 2022 •

edited

Loading

lguohan Jun 23, 2022

jiahua-wang Jun 30, 2022

lguohan Jul 25, 2022

jiahua-wang Jul 25, 2022

lguohan Jul 25, 2022

jiahua-wang Jul 25, 2022

lguohan commented Jun 23, 2022

kcudnik commented Jun 24, 2022

jimmyzhai Aug 2, 2022

jiahua-wang Sep 8, 2022

jimmyzhai Aug 2, 2022

jiahua-wang Aug 4, 2022 •

edited

Loading

Add switch api for clause 22 mdio access #1507

Add switch api for clause 22 mdio access #1507

Conversation

jiahua-wang commented Jun 23, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lguohan commented Jun 23, 2022

kcudnik commented Jun 24, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jiahua-wang Aug 4, 2022 • edited Loading

Choose a reason for hiding this comment

jiahua-wang commented Jun 23, 2022 •

edited

Loading

jiahua-wang Aug 4, 2022 •

edited

Loading