Add attributes to disable L3 rewrites #1924
Conversation
- Src MAC disable - Dst MAC disable - Vlan rewrite disable Signed-off-by: Vivek Ramamoorthy <vivekmoorthy@google.com>
|
please fix build errors |
Signed-off-by: Vivek Ramamoorthy <vivekmoorthy@google.com>
vivekmoorthy
changed the title
Done. |
done |
|
@kcudnik @mikeberesford could you review this PR |
|
@vivekmoorthy we will need to bring this to the SAI community meeting next week. I can help coordinate |
|
Today in SAI pipeline for L3/routed packets, dst mac/src mac/vlan id are replaced in neighbor encap/egress rif block. We discussed in SAI Meeting if these knobs should be in neighbor or rif object instead. However, if disable L3 rewrite are only for certain IP flows and not for entire egress IP interface/neighbor, it'd still be better to stay at next hop object. |
Updated link to document with requirements, proposal and example in description. |
|
@JaiOCP @rlhui @srikrishnagopu @rck-innovium Pls review. I have added link document in description with example usage. |
|
@vivekmoorthy Please check in the document as MD file. |
Signed-off-by: Vivek Ramamoorthy <vivekmoorthy@google.com>
Done. |
|
@rck-innovium @marian-pritsak could you pls review |
|
@rlhui Based on discussion last week and with the approvals and comments addressed, could we merge this PR? |
|
@marian-pritsak , please help review/approve? Thanks. |
@marian-pritsak could you please help with this? |
The primary purpose of this is to bring in support for compiling on Debian Bookworm. This brings in the following changes: * Update the Doxyfile for doxygen in Debian Bookworm (opencomputeproject/SAI#1946) * Enable sai_uint16_t in ProcessStructValueType Struct Member (opencomputeproject/SAI#1949) * [meta] Add support for port stat extensions (opencomputeproject/SAI#1947) * [meta] Add custom range start end values check (opencomputeproject/SAI#1945) * Cable diagnostics attribute added (opencomputeproject/SAI#1894) * Add attributes to disable L3 rewrites (opencomputeproject/SAI#1924) * Add MAC remote loopback to the port loopback enums. (opencomputeproject/SAI#1934) * [TAM] Granular counter subscription (opencomputeproject/SAI#1670) Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
* Add atrributes to disable L3 rewrites - Src MAC disable - Dst MAC disable - Vlan rewrite disable Signed-off-by: Vivek Ramamoorthy <vivekmoorthy@google.com> Knobs for disabling rewrites to following fields Src MAC disable Dst MAC disable Vlan rewrite disable While we do L3 IP based routing, we have scenarios where we need knobs for disabling L2 field rewrites. Case 1: For some scenarios, the switch serves as an L3 passthrough. Creating nexthop/RIF for every source mac, dst-mac, vlan will not scale, and we would like to simply passthrough the L2 fields without any rewrites Case 2: For some scenarios, we set VLAN in pre-ingress stage based on certain classification, and would like to preserve this VLAN in the packet.
Knobs for disabling rewrites to following fields
While we do L3 IP based routing, we have scenarios where we need knobs for disabling L2 field rewrites.
Case 1: For some scenarios, the switch serves as an L3 passthrough. Creating nexthop/RIF for every source mac, dst-mac, vlan will not scale, and we would like to simply passthrough the L2 fields without any rewrites
Case 2: For some scenarios, we set VLAN in pre-ingress stage based on certain classification, and would like to preserve this VLAN in the packet.