[DASH] Add Routing Group API #2026
Conversation
experimental/saiextensions.h
Outdated
| @@ -81,6 +82,8 @@ typedef enum _sai_api_extensions_t | |||
|
|
|||
| SAI_API_DASH_HA, | |||
|
|
|||
| SAI_API_DASH_ROUTING_GROUP, | |||
There was a problem hiding this comment.
why this is not added at the end ? such changes will not be backward compatible later
There was a problem hiding this comment.
@r12f is there a way to control ordering in this enum?
There was a problem hiding this comment.
The current logic of generation is that we will scan all the existing attributes and ignore if the attribute is already added.
Since you are hitting this issue, it should be caused by you have generated the SAI headers in multiple branches without resetting. If you revert all the SAI changes by git reset --hard and regenerate it, it will be added in the end.
There was a problem hiding this comment.
@r12f is there a way to control ordering in this enum?
you can assign number to enum explicitly
There was a problem hiding this comment.
There's no longer a separate API, this change is removed
experimental/saitypesextensions.h
Outdated
| @@ -74,6 +74,8 @@ typedef enum _sai_object_type_extensions_t | |||
|
|
|||
| SAI_OBJECT_TYPE_HA_SCOPE, | |||
|
|
|||
| SAI_OBJECT_TYPE_ROUTING_GROUP, | |||
There was a problem hiding this comment.
why this is not added at the end ? such changes will not be backward compatible later
There was a problem hiding this comment.
this is the same problem as the API type. we need to reset the generated SAI header before generating the new one.
There was a problem hiding this comment.
Moved to the end thanks to new api gen infra.
| * @flags CREATE_AND_SET | ||
| * @default false | ||
| */ | ||
| SAI_ROUTING_GROUP_ATTR_ADMIN_STATE = SAI_ROUTING_GROUP_ATTR_START, |
There was a problem hiding this comment.
I remember this should be changed to disabled instead of admin state. But somehow it is missing?
There was a problem hiding this comment.
Changed to disabled
| _In_ uint32_t attr_count, | ||
| _Inout_ sai_attribute_t *attr_list); | ||
|
|
||
| typedef struct _sai_dash_routing_group_api_t |
There was a problem hiding this comment.
since the routing entry in DASH is outbound_routing_entry, do you mind to change this to outbound_routing_group to make them align?
also, I believe it is better to merged into outbound routing header, we can use the annotation dash_api in the p4 file to specify the API group.
There was a problem hiding this comment.
Changed and merged
marian-pritsak
force-pushed
the
rg
branch
3 times, most recently
from
d5b973b to
27ba5ae
Compare
Signed-off-by: Marian Pritsak <marianp@mellanox.com>
Add intermediate container object for outbound routing entries to attach them in all together to ENI. Signed-off-by: siqbal1986 <shahzad.iqbal@microsoft.com>
Add intermediate container object for outbound routing entries to attach them in all together to ENI.
Add intermediate container object for outbound
routing entries to attach them in all together
to ENI.