-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add label attribute for Policer, RIF, Scheduler and UDF #2046
Conversation
Does this needs to be a string ? Or it would be better to make this uint32 or 64? Maybe it's discussion for sai community meeting |
As discussed in the community meeting, the string provides the option to use the key from the application/config db entry.. |
@JaiOCP , @rck-innovium , please help review? thanks. |
what config db entry ? SAI don't have any idea about any config db entry |
@erohsik - could you please resolve branch conflicts? |
@kcudnik - Since the label is populated from the application/NOS, the general consensus was that a string would be easier to manage. Is there a concern with using a string label? |
ok, i got it now it's just a label, please resolve conflicts |
d46c39d
to
e6af1ee
Compare
You have spelling issue |
Add label attribute to a few SAI objects that will help during warmboot object matching. Signed-off-by: Kishore Gummadidala <kishorg@google.com>
Signed-off-by: Kishore Gummadidala <kishorg@google.com>
5488786
to
13ddc5d
Compare
Add label attribute to a few SAI objects that will help during warmboot object matching.