Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning: Fix for Unsigned long long usage in 32bit arch #999

Merged
merged 2 commits into from
Oct 11, 2019
Merged

Warning: Fix for Unsigned long long usage in 32bit arch #999

merged 2 commits into from
Oct 11, 2019

Conversation

antony-rheneus
Copy link
Contributor

Backported from master branch
500ba4d
5d2df18

Signed-off-by: Antony Rheneus arheneus@marvell.com

@antony-rheneus
Warning: Fix for Unsigned long long usage in 32bit arch
82b74a0 
Backported from master branch
opencomputeproject@500ba4d
opencomputeproject@5d2df18

Signed-off-by: Antony Rheneus <arheneus@marvell.com>
@antony-rheneus antony-rheneus mentioned this pull request Aug 13, 2019
Closed
@kcudnik
Copy link
Collaborator

kcudnik commented Sep 3, 2019

retest this please

@kcudnik
Copy link
Collaborator

kcudnik commented Sep 3, 2019 •
edited
Loading

since this is 1.4 branch "-I." must be added to Makefile in "perl parse.pl" command, please take a look at Master branch for meta/Makefile
this is because perl version was updated on jenkins build system

@lguohan
Copy link
Collaborator

lguohan commented Sep 5, 2019

retest this please

2 similar comments
@lguohan
Copy link
Collaborator

lguohan commented Sep 12, 2019

retest this please

@lguohan
Copy link
Collaborator

lguohan commented Oct 10, 2019

retest this please

@lguohan
Copy link
Collaborator

lguohan commented Oct 10, 2019

@kcudnik , is this comment for me? do i need to change the jenkins's build script?

since this is 1.4 branch "-I." must be added to Makefile in "perl parse.pl" command, please take a look at Master branch for meta/Makefile
this is because perl version was updated on jenkins build system

@kcudnik
Copy link
Collaborator

kcudnik commented Oct 10, 2019 •
edited
Loading

no, this is comment to @antony-rheneus , Makefile script needs to be updated as in the master, to add -I., take a look at https://github.com/opencomputeproject/SAI/pull/950/files

@antony-rheneus
Copy link
Contributor Author

no, this is comment to @antony-rheneus , Makefile script needs to be updated as in the master, to add -I., take a look at https://github.com/opencomputeproject/SAI/pull/950/files

Oh, ok thanks, I thought comment was not for me. WIll update Makefile

@antony-rheneus
[Makefile] Port perl parsese.pl from master branch
45c4f26 
Signed-off-by: Antony Rheneus <arheneus@marvell.com>
@kcudnik kcudnik merged commit f5ea7b7 into opencomputeproject:v1.4 Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcudnik kcudnik kcudnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antony-rheneus @kcudnik @lguohan