-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.0.0] Need actual independent implementations #126
Comments
The OCI image format is not different than the Docker image format. Changing the single media-type string constant doesn't make the format schema different. And on top of that we have added tests, documentation, JSON schema, etc. We have one independent implementation of the specification, the My opinion: it would be nice to have independent implementations ahead of the release but we are hitting a chicken-and-egg situation here and delaying a release isn't going to fix the situation. The OCI is mandated in the governance docs to be compatible, section 7.g:
And the format we have here today is schema identical with systems widely used in production: Docker Hub, Docker Engine, rkt, etc. |
AFAICS this code (specifically the unpacking code) was merged 8 days ago. Am I misunderstanding something? The validation code is older than that, but my understanding of image-spec is that we define a format so that people can implement unpacking tools. Ours has only been in mainline for a week(!).
Who decided that we have to release Also, can I please draw our attention to the fact that the "examples" in the
So it should be trivial to write PRs to get code merged upstream, right? If it's schematically identical, all of the differences are minor, etc -- why don't we actually write some code and merge it upstream to prove that we are serious about |
@cyphar The decision and rough milestones were ratified by the OCI TOB in March of 2016. You can find the mailing list thread here: https://groups.google.com/a/opencontainers.org/d/msg/tob/KGyPpu8YfNk/JnOvOEdSBQAJ |
@philips Do all maintainers still agree with the roadmap? It doesn't look like the community agrees IMO. Maybe we should hold another vote? |
See also https://tools.ietf.org/html/rfc5657 |
@philips mentioned rkt now supports OCI image format https://groups.google.com/a/opencontainers.org/d/msg/dev/Am7byGvLCUQ/ywbuVLY3BQAJ |
Skopeo now supports OCI image format and layout https://github.com/projectatomic/skopeo, via the https://github.com/containers/image library. /cc @runcom |
rkt supports fetching and running OCI images: https://groups.google.com/a/opencontainers.org/forum/#!topic/dev/Am7byGvLCUQ |
Here is the docker proposal for OCI support: moby/moby#25779. |
I think this is done now |
(this issue) |
here is the WIP Docker PR for OCI support moby/moby#26369 |
Criteria:
|
Mesos is working on OCI support atm: https://issues.apache.org/jira/browse/MESOS-5011 Design doc: https://docs.google.com/document/d/1Pus7D-inIBoLSIPyu3rl_apxvUhtp3rp0_b0Ttr2Xww/edit?usp=sharing |
I am satisfied this is heading in the right direction; can someone put a README entry together with all of this? |
On Sun, Oct 23, 2016 at 10:56:25AM -0700, Brandon Philips wrote:
There's a lot of stuff in the current image-spec README. Do we want |
@wking an implementations doc seems like a great idea! |
Amazon Elastic Container Registry (ECR) has added support to pull OCI images. https://docs.aws.amazon.com/AmazonECR/latest/userguide/image-manifest-formats.html |
I think this is good. Perhaps best to have a wiki page or similar for listing these things. |
oh we've disabled wiki. fair... perhaps just close this and folks can add comments if they feel inclined? Seems like it ought to be tracked somewhere, but not keeping this issue open indefinitely |
Fixes opencontainers#126 Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
Fixes opencontainers#126 Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
Fixes opencontainers#126 Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
Fixes opencontainers#126 Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
Fixes opencontainers#126 Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
Currently we don't have any canonical independent implementations of the specification. Docker's image format is different to ours (even though the base came from them), and rkt doesn't have support for ours.
As a result, this spec is entirely untested as we don't have any code implementing the spec word-for-word. As several people have discussed on the mailing list, this should be considered a blocking issue for 1.0.
Personally, I would want to have two implementations of the image-spec (like we do with the runtime-spec) before we can consider this ready. Preferably these implementations would be part of Docker and rkt (and have a reasonable cook time).
The text was updated successfully, but these errors were encountered: