Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

image-layout: add explanation of the refs directory use case for tags #225

Merged
merged 1 commit into from
Aug 31, 2016
Merged

image-layout: add explanation of the refs directory use case for tags #225

merged 1 commit into from
Aug 31, 2016

Conversation

philips
Copy link
Contributor

@philips philips commented Aug 31, 2016

Signed-off-by: Brandon Philips brandon.philips@coreos.com

image-layout: add explanation of the refs directory use case for tags
79d0c7f 
Signed-off-by: Brandon Philips <brandon.philips@coreos.com>
@philips
Copy link
Contributor Author

philips commented Aug 31, 2016

cc @runcom

@philips philips mentioned this pull request Aug 31, 2016
Closed
@philips philips added this to the v0.5.0 milestone Aug 31, 2016
@wking
Copy link
Contributor

wking commented Aug 31, 2016 via email

@runcom
Copy link
Member

runcom commented Aug 31, 2016

LGTM (IANAM)

@vbatts
Copy link
Member

vbatts commented Aug 31, 2016 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@stevvooe
Copy link
Contributor

@philips Are we not standardizing on the refs/tags convention?

@philips
Copy link
Contributor Author

philips commented Aug 31, 2016

@stevvooe If you want to try and do that. I couldn't articulate a good reason for refs/tags besides "future use". So, I am fine with this as-is as long as an explanation is clear enough for @runcom who originally was confused around the use-case of refs.

@stevvooe
Copy link
Contributor

stevvooe commented Aug 31, 2016 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@stevvooe stevvooe merged commit 4b41db2 into opencontainers:master Aug 31, 2016
@wking wking mentioned this pull request Sep 15, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@philips @wking @runcom @vbatts @stevvooe