Fix "manifest list" typos for manifest annotations #484
Conversation
zhouhao3
force-pushed
the
json-test
branch
4 times, most recently
from
1c10a05
to
3afd985
Compare
|
@stevvooe @vbatts @jonboulle PTAL |
|
@q384566678 I have no clue what this PR is doing. Please expand on "Modify the error message". What is this fixing? |
|
@stevvooe Should be a writing error, manifest the annotations field id should be |
|
@q384566678 What should be writing an error? Do you have an example of what happens with and without this patch? |
|
@stevvooe Uh, if not revised, then there should not be any mistakes. I think here mainly belongs to writing errors. |
|
@stevvooe @vbatts @philips I have updated this PR, I think these two should be modified. It can be seen from the specification that manifest list and image manifest are different in |
zhouhao3
force-pushed
the
json-test
branch
2 times, most recently
from
0b1750c
to
4bf977f
Compare
|
@q384566678 Are you saying that this is missing? Could you provide an example of the output before and after this change? |
zhouhao3
force-pushed
the
json-test
branch
11 times, most recently
from
405a5fc
to
65c7095
Compare
|
@stevvooe Uh......I mean that in my two changes, the manifest and manifest list confused, if not changed, then it will not be wrong, because it is only the role of the description, not the specific data call. |
|
65c7095 looks good to me. image-manifest-schema.json should not
have manifest-list IDs and manifest.go should not mention manifest
lists in its comments. I expect both were copy/paste errors from when
annotations were added to manifests, but I haven't gone back into the
Git history to confirm that.
|
|
On Tue, Feb 14, 2017 at 11:56:44AM -0800, W. Trevor King wrote:
65c7095 looks good to me…
The PR subject and commit message summary are pretty bad though ;).
Maybe “Fix "manifest list" typos for manifest annotations”?
|
zhouhao3
changed the title
My title does have a problem.updated.thanks. |
|
On Tue, Feb 14, 2017 at 05:37:36PM -0800, Zhou Hao wrote:
My title does have a problem.updated.thanks.
Want to update the commit message as well?
|
zhouhao3
force-pushed
the
json-test
branch
2 times, most recently
from
c60e494
to
fe58859
Compare
Signed-off-by: zhouhao <zhouhao@cn.fujitsu.com>
|
LGTM |
|
lgtm |
Signed-off-by: zhouhao zhouhao@cn.fujitsu.com