specs-go/v1: use digest type on descriptor #514
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen J Day <stephen.day@docker.com>
xiekeyang
reviewed
Jan 20, 2017
| @@ -14,13 +14,15 @@ | |||
|
|
|||
| package v1 | |||
|
|
|||
| import digest "github.com/opencontainers/go-digest" | |||
There was a problem hiding this comment.
import "github.com/opencontainers/go-digest" is OK?
There was a problem hiding this comment.
Go tool does this automatically.
|
The Travis errors are all git-validation looking at ancient commits
[1]. This looks a lot like [2]. And while I'm not sure if
opencontainers/runtime-spec#216 will fix this particular issue, the
TRAVIS_COMMIT_RANGE echo it adds will help debug things like this.
[1]: https://travis-ci.org/opencontainers/image-spec/builds/193543329#L303
[2]: opencontainers/runtime-spec#660 (comment)
|
|
@caniszczyk @vbatts @philips Any idea what is going on here? What is this second builder "push" doing? |
|
@opencontainers/image-spec-maintainers PTAL |
|
why is the git-validation DCO check failing? cc: @vbatts |
|
also the DCO check is completed via PullApprove now so things are somewhat redundant imho |
|
@caniszczyk I have no clue. |
|
On Mon, Jan 23, 2017 at 03:27:15PM -0800, Chris Aniszczyk wrote:
also the DCO check is completed via PullApprove now so things are
somewhat redundant imho
Some of the failures are for trailing whitespace (e.g. [1]), so I
think we want to keep the git-validation checks (they are also
something folks can run locally). The problem is that Travis isn't
running git-validation on the right commit set, although I'm not sure
why not. Echoing TRAVIS_COMMIT_RANGE (or just running ‘env’?) would
help figure out why the commit set is wrong [2].
@stevvooe, the /push tests are for the branch itself, and the /pr
tests are for the branch as merged into master [3,4]. Maybe we should
be using the epoch commit [5] for the push tests?
[1]: https://travis-ci.org/opencontainers/image-spec/builds/193543329#L304
[2]: #514 (comment)
[3]: http://stackoverflow.com/a/41534988
[4]: https://docs.travis-ci.com/user/pull-requests/#How-Pull-Requests-are-Tested
[5]: https://github.com/opencontainers/image-spec/blob/v1.0.0-rc3/Makefile#L42
|
|
On Mon, Jan 23, 2017 at 03:37:54PM -0800, W. Trevor King wrote:
Maybe we should be using the epoch commit [5] for the push tests?
Potential fix along these lines filed as #521, although there's no
/push test there. I suspect the /push test here is because you're
using a branch inside this repo (vs. filing the PR from a branch in
your personal fork).
|
This may be it. My |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stephen J Day stephen.day@docker.com
cc @opencontainers/image-spec-maintainers