schema/fs: Drop *.go files #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With: $ go get -u github.com/mjibson/esc $ make schema/fs.go now that 6f633c2 (schema/gen: Include .json instead of excluding .go, 2017-01-27, opencontainers#538) has landed. Signed-off-by: W. Trevor King <wking@tremily.us>
|
while i like this idea, this also means the code can not be |
|
On Thu, Mar 09, 2017 at 11:07:37AM -0800, Vincent Batts wrote:
while i like this idea, this also means the code can not be `go
get`ten and vendor'ed, right?
This has no impact on ‘go get’, since all the schema/*.go is still
there. All I'm doing is removing *.go which had been bundled into
fs.go. All we use fs.go for is the *.json files, and those are
still there [1].
[1]: https://github.com/wking/image-spec/blob/5e79bb5ba4c9ab85f6e115372cb9608750dceab4/schema/fs.go#L205
|
|
k. Prolly should add it to |
? |
|
i misunderstood. I thought (hoped?) you meant that schema/fs.go is removed and only generated as needed. |
Well, only generated when |
|
LGTM
we could try this elsewhere but this change is fine for now |
|
LGTM |
Merged
wking
added a commit
to wking/image-spec
that referenced
this pull request
Sep 18, 2017
…ure" Adjusting wording we've been carrying since 9bb56d8 (image-layout: add an initial image layout spec, 2016-05-26, opencontainers#605). On Windows, an unpacked layout will use backslashes. Layouts really don't care what the directory separator is, and each access method (filesytem access, tar unpacker, etc.) already has an unambiguous separator character. Signed-off-by: W. Trevor King <wking@tremily.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With:
now that #538 has landed.