use a bulleted list for rules in many places #612
Conversation
|
would we want to do this more broadly? |
|
LGTM |
|
Yeah I will do it!
…On Tue, Mar 14, 2017 at 8:52 AM, Vincent Batts ***@***.***> wrote:
LGTM
and sure it could be applied to other places as well
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#612 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABJ69OYXtKtcoEMik-wDFNc6Wu3glChks5rlreygaJpZM4McOLw>
.
|
erikh
force-pushed
the
annotations-cleanup
branch
from
269fe7a
to
eb8d5da
Compare
Signed-off-by: Erik Hollensbe <github@hollensbe.org>
erikh
force-pushed
the
annotations-cleanup
branch
from
2ffec8a
to
5075201
Compare
erikh
changed the title
|
I've expanded things a bit to include lists in other places. Hopefully it works. I will do more just at a later point. Please consider this ready for merge unless it needs edits. |
|
LGTM |
1 similar comment
|
LGTM |
|
ugh, I'm not so happy about this; it doesn't make sense in sections that are English prose. |
|
sorry! Let me know what you're objecting to and I will revert it manually.
…On Thu, Mar 16, 2017 at 6:18 AM, Jonathan Boulle ***@***.***> wrote:
ugh, I'm not so happy about this; it doesn't make sense in sections that
are English prose.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#612 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABJ63M4sAo7Op_BOpMnqWcBGmP_BvNZks5rmTaQgaJpZM4McOLw>
.
|
|
@erikh I actually agree with @jonboulle here. This does not help readability. |
|
@vbatts Can we revert this? |
|
I guess, but it would be post-v1.0.0 |
|
Seems like this can go in the v1.0.0. This is pretty awful. |
|
I can revert it this weekend.
…On Thu, Jul 6, 2017 at 11:41 AM, Stephen Day ***@***.***> wrote:
Seems like this can go in the v1.0.0. This is pretty awful.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#612 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABJ6ymAsZB2dZ8eWyCfqhIwhATZKB6Kks5sLSpsgaJpZM4McOLw>
.
|
|
@erikh Thanks! But it looks like this will go out with the 1.0. |
|
Do you want me to do it or not?
…On Thu, Jul 6, 2017 at 1:11 PM, Stephen Day ***@***.***> wrote:
@erikh <https://github.com/erikh> Thanks! But it looks like this will go
out with the 1.0.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#612 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABJ60BBZNcoa43MLFZA5g6CJ5yeH7Ppks5sLT9ogaJpZM4McOLw>
.
|
|
@erikh Yes, please, but it may not be merged immediately. |
|
I'm sorry, I won't have the time to do this, nor will I have much to spend on opencontainers in general. Sorry if I caused any trouble. Thank you for letting me be involved in the past! |
|
@stevvooe this revert is going to have to be manually done. |
|
@vbatts Yes, agreed. I'll take care of it after 1.0. |
|
👍
…On Mon, Jul 10, 2017 at 2:02 PM Stephen Day ***@***.***> wrote:
@vbatts <https://github.com/vbatts> Yes, agreed. I'll take care of it
after 1.0.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#612 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEF6QrZt8qTt4E2gW2IHa3GolVVJ28fks5sMmc2gaJpZM4McOLw>
.
|
Hope this is a welcome change. Thanks!