schema: Update the json file #638
Conversation
Signed-off-by: zhouhao <zhouhao@cn.fujitsu.com>
There was a problem hiding this comment.
On thinking about this further I am not sure this makes things clearer, given that we still need to retain the qualification (here) in the image-index description. Perhaps it would make more sense to leave platform where it is, and instead simply augment the descriptor description here to mention that "descriptors pointing to certain types may include extended fields" or similar ..?
| @@ -43,32 +43,6 @@ For the media type(s) that this document is compatible with, see the [matrix][ma | |||
| This OPTIONAL property describes the platform which the image in the manifest runs on. | |||
There was a problem hiding this comment.
line 28 should be changed from "with the following additional properties and restrictions" to "with the following requirements and restrictions" or similar
There was a problem hiding this comment.
updated, what do you think of 3e7b8d0.
|
Platform shouldn't be valid on descriptors outside usage on the index. While we've changed the Go datatype to make processing easier, the specification still reads correctly. |
|
I missed #638 (review).
This is probably the correct approach here. |
|
Agree, that should be the correct approach. |
Signed-off-by: zhouhao <zhouhao@cn.fujitsu.com>
|
I'm going to go ahead and close this favor of @jonboulle's suggestion in #638 (review). |
|
But based on @jonboulle's comment, we need to augment the descriptor description, so we still need another PR to update |
|
@qianzhangxa Yes, but this PR needs to be closed. |
Update the corresponding json file and spec file according to #620
Signed-off-by: zhouhao zhouhao@cn.fujitsu.com
Fixes #618