Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address duplicate REQUIREMENT #645

Merged

Conversation

mikebrow
Copy link
Member

We are repeating the REQUIRED statement here in image-index.md which is properly located in the forward reference document descriptor.md. All upper case terms hold special meaning see https://tools.ietf.org/html/rfc2119

Additionally as @wking points out, we're also including OPTIONAL descriptor properties in the extension, not just the REQUIRED properties.

Signed-off-by: Mike Brown brownwm@us.ibm.com

Signed-off-by: Mike Brown <brownwm@us.ibm.com>
@stevvooe
Copy link
Contributor

stevvooe commented Apr 10, 2017

LGTM

Approved with PullApprove

@wking
Copy link
Contributor

wking commented Apr 10, 2017

Chasing #583.

@vbatts
Copy link
Member

vbatts commented Apr 11, 2017

LGTM

Approved with PullApprove

@vbatts vbatts merged commit 00dfb9b into opencontainers:master Apr 11, 2017
@vbatts vbatts mentioned this pull request May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants