Add support for r/o mount labels #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch is needed for this pull request, and will probably be used by other golang programs in the future. |
|
@rhvgoyal FYI |
|
avagin, caniszczyk, crosbymichael, cyphar, dqminh, hqhq, LK4D4, mrunalp, rjnagal, vmarmol PTAL |
|
can you rebase, there is a conflict. Changes: LGTM |
We need support for read/only mounts in SELinux to allow a bunch of containers to share the same read/only image. In order to do this we need a new label which allows container processes to read/execute all files but not write them. Existing mount label is either shared write or private write. This label is shared read/execute. Signed-off-by: Dan Walsh <dwalsh@redhat.com>
|
Rebased. |
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need support for read/only mounts in SELinux to allow a bunch of
containers to share the same read/only image. In order to do this
we need a new label which allows container processes to read/execute
all files but not write them.
Existing mount label is either shared write or private write. This
label is shared read/execute.
Signed-off-by: Dan Walsh dwalsh@redhat.com