Update runtime spec to rc5 #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@crosbymichael PTAL |
|
257/264 passed on RHEL - Failed. |
|
@justincormack can you double check the cap changes |
|
LGTM |
|
Do we need to remove the |
libcontainer/configs/config.go
Outdated
| @@ -114,7 +114,7 @@ type Config struct { | |||
|
|
|||
| // Capabilities specify the capabilities to keep when executing the process inside the container | |||
| // All capbilities not specified will be dropped from the processes capability mask | |||
There was a problem hiding this comment.
may as well fix the typo above too...
|
Yes, the build tag needs to go. |
|
Pushed a commit to remove the ambient build tag. |
Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
mrunalp
force-pushed
the
update_spec_rc5
branch
from
19060f0
to
4f903a2
Compare
4 tasks
|
LGTM |
cyphar
reviewed
Mar 16, 2017
| @@ -6,7 +6,7 @@ github.com/docker/go-units 9b001659dd36225e356b4467c465d732e745f53d | |||
| github.com/godbus/dbus c7fdd8b5cd55e87b4e1f4e372cdb1db61dd6c66f | |||
| github.com/golang/protobuf/proto f7137ae6b19afbfd61a94b746fda3b3fe0491874 | |||
| github.com/mrunalp/fileutils ed869b029674c0e9ce4c0dfa781405c2d9946d08 | |||
| github.com/opencontainers/runtime-spec/specs-go 794ca7ac88234607f9d2c76da8a6e9bbbade8cb9 | |||
| github.com/opencontainers/runtime-spec/specs-go 035da1dca3dfbb00d752eb58b0b158d6129f3776 | |||
There was a problem hiding this comment.
I'd prefer if we used tags here...
|
LGTM, aside from the nit. Feel free to merge. |
|
LGTM |
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 7, 2017
The format of the capabilities section in config.json was changed in the runtime spec 1.0.0.rc5 (pulled in through PR opencontainers#1370). Update the example in README.md correspondingly. Also fix a small typo (though -> through). Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
The format of the capabilities section in config.json was changed in the runtime spec 1.0.0.rc5 (pulled in through PR opencontainers#1370). Update the example in README.md correspondingly. Also fix a small typo (though -> through). Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
kolyshkin
added a commit
to kolyshkin/runc
that referenced
this pull request
Mar 15, 2020
This build tag was removed in commit 4f903a2 (PR opencontainers#1370) quite some time ago. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mrunal Patel mrunalp@gmail.com