Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: set go_import_path to github.com/opencontainers/runc #1388

Merged
merged 1 commit into from
Jun 12, 2017

Conversation

avagin
Copy link
Contributor

@avagin avagin commented Mar 23, 2017

If someone forks runc and wants to check changes in travis, he will find
that the command 'make BUILDTAGS="${BUILDTAGS}"' fails, because
github.com/opencontainers/runc/ is used in many places to import
packages (e.g. libcontainer).

Signed-off-by: Andrei Vagin avagin@virtuozzo.com

@rh-atomic-bot
Copy link

258/265 passed on RHEL - Failed.
224/234 passed on CentOS - Failed.
263/264 passed on Fedora - Failed.
Log - https://aos-ci.s3.amazonaws.com/opencontainers/runc/runc-integration-tests-prs/305/fullresults.xml

@avagin
Copy link
Contributor Author

avagin commented Mar 23, 2017

@vbatts git-validation doesn't work if I pushed my changes into the my runc repo. Can we do something with this?
https://travis-ci.org/avagin/runc/jobs/214068100

0.01s$ git-validation -run DCO,short-subject -v
ERRO[0000] mm[git] cmd: "git --no-pager log --pretty=format:%H eec6c2a693ca..1e97db11aeac" 
2017/03/23 00:20:12 exit status 128

@vbatts
Copy link
Member

vbatts commented Mar 23, 2017

@avagin yes, i really want to see a reliable way to do these checks with travis. In the link you provided, the commit-range eec6c2a..1e97db1 does not exist for your travis branch on https://github.com/avagin/runc.git
I will look into the TRAVIS_ env variables provided to see what might be more reliable than TRAVIS_COMMIT_RANGE

@avagin
Copy link
Contributor Author

avagin commented Mar 23, 2017

@vbatts when I am preparing a patch series, I do git rebase -i origin/master and then git push --force avagin HEAD:branch. I think the --force option is a reason why TRAVIS_COMMIT_RANGE doesn't work in this case.

@vbatts
Copy link
Member

vbatts commented Mar 23, 2017

@avagin i'm currently at a loss for this use-case 😬

If someone forks runc and wants to check changes in travis, he will find
that the command 'make BUILDTAGS="${BUILDTAGS}"' fails, because
github.com/opencontainers/runc/ is used in many places to import
packages (e.g. libcontainer).

Signed-off-by: Andrei Vagin <avagin@virtuozzo.com>
@avagin
Copy link
Contributor Author

avagin commented Jun 9, 2017

With this patch, anyone can push changes in his own repo and check that nothing failed in travis.
For example: https://travis-ci.org/avagin/runc/builds/241371998

@avagin
Copy link
Contributor Author

avagin commented Jun 10, 2017

And here is an example how it looks like without this patch.
https://travis-ci.org/avagin/runc/jobs/241395776

@avagin
Copy link
Contributor Author

avagin commented Jun 10, 2017

ping @opencontainers/runc-maintainers

@dqminh
Copy link
Contributor

dqminh commented Jun 12, 2017

LGTM

Approved with PullApprove

1 similar comment
@crosbymichael
Copy link
Member

crosbymichael commented Jun 12, 2017

LGTM

Approved with PullApprove

@crosbymichael crosbymichael merged commit c995ee4 into opencontainers:master Jun 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants