-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
travis: set go_import_path to github.com/opencontainers/runc #1388
Conversation
258/265 passed on RHEL - Failed. |
@vbatts git-validation doesn't work if I pushed my changes into the my runc repo. Can we do something with this?
|
@avagin yes, i really want to see a reliable way to do these checks with travis. In the link you provided, the commit-range eec6c2a..1e97db1 does not exist for your |
@vbatts when I am preparing a patch series, I do git rebase -i origin/master and then git push --force avagin HEAD:branch. I think the --force option is a reason why TRAVIS_COMMIT_RANGE doesn't work in this case. |
@avagin i'm currently at a loss for this use-case 😬 |
If someone forks runc and wants to check changes in travis, he will find that the command 'make BUILDTAGS="${BUILDTAGS}"' fails, because github.com/opencontainers/runc/ is used in many places to import packages (e.g. libcontainer). Signed-off-by: Andrei Vagin <avagin@virtuozzo.com>
With this patch, anyone can push changes in his own repo and check that nothing failed in travis. |
And here is an example how it looks like without this patch. |
ping @opencontainers/runc-maintainers |
If someone forks runc and wants to check changes in travis, he will find
that the command 'make BUILDTAGS="${BUILDTAGS}"' fails, because
github.com/opencontainers/runc/ is used in many places to import
packages (e.g. libcontainer).
Signed-off-by: Andrei Vagin avagin@virtuozzo.com