Revert back to using /sbin #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was changed in opencontainers@d2f49696#diff-b67911656ef5d18c4ae36cb6741b7965R7 and is causing install problems for people building runc and having it installed in /bin and /sbin. Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
|
This change was probably made during development and forgotten/missed in code review. |
|
It was intentional (it's no longer software that only admins can use), but I didn't realise this would cause issues. LGTM. |
|
Ya, the issue was |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was changed in
d2f49696#diff-b67911656ef5d18c4ae36cb6741b7965R7
and is causing install problems for people building runc and having it
installed in /bin and /sbin.
Signed-off-by: Michael Crosby crosbymichael@gmail.com