*: fix shfmt #1505
*: fix shfmt #1505
Conversation
Recent changes in upstream shfmt have started causing our scripts to no longer be "correctly formatted". Fix up with `shfmt -w`. Signed-off-by: Aleksa Sarai <asarai@suse.de>
|
This fixes the failures in #1504. |
|
LGTM should we pin the commit for shfmt so contributors don't run into this type of thing on their PRs when upstream changes? |
|
Most likely, but we'd have to replace the |
|
LGTM |
|
Darn, this is a regression :) And yes, you should pin versions. You can use binaries from https://github.com/mvdan/sh/releases too, if you wish. |
|
Fixed here: mvdan/sh@4c56b4c |
|
@mvdan i think pinning 1.3.1 is not working for us now since we made changes that is incompatible with it. Do you want to do a release then we will pin it here ? |
|
I plan on doing 2.0 very soon - probably in the next week - but I can't do it right now. Want to make sure I'm not missing anything related to breaking changes. And I haven't fuzzed master thoroughly yet. I don't plan on doing any more refactors like the one that introduced this regression however, so you should be fine. |
|
@mvdan I was wondering if this was a regression, because it's odd to require trailing whitespace. I'll re-send an un-fix for this. 😉 |
Recent changes in upstream shfmt have started causing our scripts to no
longer be "correctly formatted". Fix up with
shfmt -w.Signed-off-by: Aleksa Sarai asarai@suse.de