Use netgo for static build
#1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 30, 2017
|
I'd recommend also using |
|
Thanks @tianon for pointing to |
|
ping @crosbymichael any idea who to ping here to get this moving? |
|
@thaJeztah a passing build is first |
|
oh, dang, sorry 😊 @yongtang can you have a look why CI is failing? |
This fix adds `netgo` to tags for static build so that the following warning could be addressed: ``` /tmp/go-link-355596637/000000.o: In function `_cgo_b0c710f30cfd_C2func_getaddrinfo': /tmp/go-build/net/_obj/cgo-gcc-prolog:46: warning: Using 'getaddrinfo' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking ``` The above warning appears when building `make static` with go 1.9. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
This fix adds `-installsuffix netgo` in static build in combination of `-tags netgo`. See following for the reason: golang/go#9369 (comment) Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
|
@crosbymichael @thaJeztah The PR has been rebased and now tests passed. Please take a look and let me know if there are any issues. |
|
LGTM |
1 similar comment
|
LGTM |
cyphar
added a commit
that referenced
this pull request
Sep 11, 2017
Add `-installsuffix netgo` in static build Use `netgo` for static build LGTMs: @crosbymichael @cyphar Closes #1577
|
Thanks! |
yongtang
added a commit
to yongtang/docker
that referenced
this pull request
Sep 26, 2017
This fix updates runc to 0351df1c5a66838d0c392b4ac4cf9450de844e2d With this fix the warnings generated by netgo and dlopen by go 1.9 are addressed. See - opencontainers/runc#1577 - opencontainers/runc#1579 This fix is part of the efforts for go 1.9 (moby#33892) Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
andrewhsu
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Sep 27, 2017
This fix updates runc to 0351df1c5a66838d0c392b4ac4cf9450de844e2d With this fix the warnings generated by netgo and dlopen by go 1.9 are addressed. See - opencontainers/runc#1577 - opencontainers/runc#1579 This fix is part of the efforts for go 1.9 (#33892) Signed-off-by: Yong Tang <yong.tang.github@outlook.com> Upstream-commit: e0ff1d1 Component: engine
salah-khan
pushed a commit
to salah-khan/moby
that referenced
this pull request
Nov 15, 2017
This fix updates runc to 0351df1c5a66838d0c392b4ac4cf9450de844e2d With this fix the warnings generated by netgo and dlopen by go 1.9 are addressed. See - opencontainers/runc#1577 - opencontainers/runc#1579 This fix is part of the efforts for go 1.9 (moby#33892) Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix adds
netgoto tags for static build so that the following warning could be addressed:The above warning appears when building
make staticwith go 1.9.Signed-off-by: Yong Tang yong.tang.github@outlook.com