Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update criu_opts_linux.go #1667

Merged
merged 1 commit into from
Dec 11, 2017
Merged

Update criu_opts_linux.go #1667

merged 1 commit into from
Dec 11, 2017

Conversation

allencloud
Copy link
Contributor

fix a typo.

@cyphar
Copy link
Member

cyphar commented Dec 5, 2017

You need to add a Signed-off-by: line to your commit(s) which indicates that you attest the Developer Certificate of Origin a statement about your contributions that you must read before signing (don't worry, it's quite short and easy-to-read). You can add it to your commits with git commit --amend -s, and then doing a git push --force.

@allencloud
Copy link
Contributor Author

allencloud commented Dec 5, 2017 •
edited
Loading

OK, I will try that. Since I update this directly on github. Updated, PTAL @cyphar

@allencloud
Update criu_opts_linux.go
fec6b0f 
Signed-off-by: Allen Sun <shlallen1990@gmail.com>
TomSweeneyRedHat
TomSweeneyRedHat reviewed Dec 5, 2017
View reviewed changes
Copy link

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@allencloud
Copy link
Contributor Author

Any update?

@hqhq
Copy link
Contributor

hqhq commented Dec 11, 2017 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

1 similar comment
@crosbymichael
Copy link
Member

crosbymichael commented Dec 11, 2017 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@crosbymichael crosbymichael merged commit 0fdc908 into opencontainers:master Dec 11, 2017
@allencloud allencloud deleted the patch-2 branch December 12, 2017 01:56
@cyphar cyphar mentioned this pull request Feb 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@allencloud @cyphar @hqhq @crosbymichael @TomSweeneyRedHat