Update build dependencies in Dockerfile #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DCOs are missing. |
This also remove jessie-backport version of libseccomp and just use stretch bundled version Signed-off-by: Daniel Dao <dqminh89@gmail.com>
The current version of criu bundled in dockerfile failed to do checkpoint/restore test on my system (v4.14.14). Upgrade to latest version v3.7 and also change the repository name to point to the current official repo. Signed-off-by: Daniel Dao <dqminh89@gmail.com>
dqminh
force-pushed
the
update-build-dep
branch
from
370cec5
to
8be3162
Compare
|
@cyphar updated 🤦♂️ Also updated golang version to 1.10 instead of 1.9. |
|
LGTM. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrade golang version in dockerfile to 1.10, image version from jessie to stretch, and criu version to v3.7. Because of the bump from jessie -> stretch, libseccomp is also bumped to 2.3.1-2.1