Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add type casting for uint64 parameter #1769

Closed
wants to merge 1 commit into from

Conversation

sangyun-han
Copy link

Add type casting for major.unix method. Its input parameter is uint64, but the parameter in unix.Stat_t is int32.

@cyphar
Copy link
Member

cyphar commented Mar 28, 2018

You need to add a Signed-off-by: line to your commit(s) which indicates that you attest the Developer Certificate of Origin a statement about your contributions that you must read before signing (don't worry, it's quite short and easy-to-read). You can add it to your commits with git commit --amend -s, and then doing a git push --force.

Signed-off-by: sangyun-han <sangyun0628@khu.ac.kr>
@sangyun-han
Copy link
Author

I added Signed-off-by.
Thank you for the comment.

@dqminh
Copy link
Contributor

dqminh commented May 19, 2018

LGTM.

I believe this is only uint32 for MIPS though.

Approved with PullApprove

@cyphar
Copy link
Member

cyphar commented Jun 25, 2018

Closing since #1824 was merged (which is basically the same thing). Thanks.

@cyphar cyphar closed this Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants