Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set unix.MS_BIND flag for bind mount #1799

Closed
wants to merge 1 commit into from

Commits on May 8, 2018

  1. set unix.MS_BIND flag for bind mount

    always set unix.MS_BIND flag for bind mount, this fixs a error reporting
    "no such device" with following  mount configration, which is similar to
    mount --bind oldidr newdir
    
    {
         "destination": "/host_dir",
         "type": "bind",
         "source": "host_dir"
    }
    
    Without this change, we always have to set the "options":
    ["rbind"], which will add the flag unix.MS_BIND in parseMountOptions.
    
    Alternative fix is to add option "bind" to Mount.Options when it is bind
    mount so the right flag can be set in parseMountOptions.
    
    Signed-off-by: Bin Chen <nk@devicu.com>
    binchenX committed May 8, 2018
    Configuration menu
    Copy the full SHA
    bb03c1b View commit details
    Browse the repository at this point in the history