Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libcontainer: fix compilation on GOARCH=arm GOARM=6 (32 bits) #1819

Merged
merged 1 commit into from
Jun 15, 2018
Merged

libcontainer: fix compilation on GOARCH=arm GOARM=6 (32 bits) #1819

merged 1 commit into from
Jun 15, 2018

Conversation

tiborvass
Copy link
Contributor

@tiborvass tiborvass commented Jun 14, 2018 •
edited by cyphar
Loading

This fixes the following compilation error on 32bit ARM:

$ GOARCH=arm GOARCH=6 go build ./libcontainer/system/
libcontainer/system/linux.go:119:89: constant 4294967295 overflows int

Signed-off-by: Tibor Vass tibor@docker.com

Related to #1688
Fixes #1818

@AkihiroSuda
Copy link
Member

seccomp_test.go:365: time="2018-06-14T18:07:54Z" level=fatal msg="panic from initialization: parseLine only accepts {*string, *int, *[]string} as arguments! (*int64)(0xc420013500) is not a pointer!, goroutine 1 [running, locked to thread]:

I think we can just add *int64 to

runc/libcontainer/user/user.go

Line 113 in 0e56164

case *int:

@tiborvass tiborvass force-pushed the fix-arm32bit branch 2 times, most recently from 377c69b to 6c937ad Compare June 14, 2018 18:32
libcontainer: fix compilation on GOARCH=arm GOARM=6 (32 bits)
c205e9f 
This fixes the following compilation error on 32bit ARM:
```
$ GOARCH=arm GOARCH=6 go build ./libcontainer/system/
libcontainer/system/linux.go:119:89: constant 4294967295 overflows int
```

Signed-off-by: Tibor Vass <tibor@docker.com>
AkihiroSuda
AkihiroSuda approved these changes Jun 14, 2018
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM(IANAM) if green, thanks!

seemethere
seemethere approved these changes Jun 14, 2018
View reviewed changes
Copy link

@seemethere seemethere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Jun 15, 2018
Closed
Closed
@cyphar
Copy link
Member

cyphar commented Jun 15, 2018 •
edited by caniszczyk
Loading

LGTM.

Approved with PullApprove

@mrunalp
Copy link
Contributor

mrunalp commented Jun 15, 2018 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@mrunalp mrunalp merged commit ad0f525 into opencontainers:master Jun 15, 2018
@seemethere seemethere mentioned this pull request Jun 15, 2018
Merged
@tiborvass
Copy link
Contributor Author

Thank you very much!

@tiborvass tiborvass deleted the fix-arm32bit branch June 15, 2018 18:29
AkihiroSuda added a commit to AkihiroSuda/buildkit_poc that referenced this pull request Jun 15, 2018
@AkihiroSuda
vendor runc ad0f5255060d36872be04de22f8731f38ef2d7b1
7690ff1 
For opencontainers/runc#1819

Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
This was referenced Jun 15, 2018
Merged
Merged
@petrosagg petrosagg mentioned this pull request Aug 11, 2018
Open
@tianon tianon mentioned this pull request Sep 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@seemethere seemethere seemethere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build fails with GOOS=linux GOARCH=386 due to int overflow
5 participants
@tiborvass @AkihiroSuda @cyphar @mrunalp @seemethere