Add docker proxy settings for make test in a proxy environment #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
AkihiroSuda
reviewed
Aug 2, 2018
| You can run a test in your proxy environment by setting `DOCKER_BUILD_PROXY` and `DOCKER_RUN_PROXY` variables. | ||
|
|
||
| ```bash | ||
| # make test DOCKER_BUILD_PROXY="--build-arg HTTP_PROXY=http://yourproxy/" DOCKER_RUN_PROXY="-e HTTP_PROXY=http://yourproxy/" |
There was a problem hiding this comment.
Should not these be DOCKER_BUILD_FLAGS and DOCKER_RUN_FLAGS?
There was a problem hiding this comment.
@AkihiroSuda Thank you for your comments. I thought these variables should be only used for proxy settings and named these variables. But either is fine.
|
ping @opencontainers/runc-maintainers @AkihiroSuda I'm thinking that I'll use original variables names if someone doesn't deny. Could someone give me comments or review? |
|
@KentaTada Needs rebase. |
This commit modifies Makefile to execute `make test` in a proxy environment. Signed-off-by: Kenta Tada <Kenta.Tada@sony.com>
KentaTada
force-pushed
the
add-docker-proxy-settings-for-test-in-makefile
branch
from
247f25d
to
b399167
Compare
|
@hqhq Thank you for your review and I rebase it. |
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
make testcannot be executed in a proxy environment. This commit resolves it.Signed-off-by: Kenta Tada Kenta.Tada@sony.com