Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes for CRIU based test cases #1936

Merged
merged 1 commit into from
Nov 20, 2018

Conversation

adrianreber
Copy link
Contributor

This removes unnecessary lines from checkpoint.bats like:

sed -i 's;"readonly": true;"readonly": false;' config.json

and adds (and corrects) comments which are leftover from older
versions of checkpoint.bats.

Signed-off-by: Adrian Reber areber@redhat.com

This removes unnecessary lines from checkpoint.bats like:

 sed -i 's;"readonly": true;"readonly": false;' config.json

and adds (and corrects) comments which are leftover from older
versions of checkpoint.bats.

Signed-off-by: Adrian Reber <areber@redhat.com>
@adrianreber
Copy link
Contributor Author

There is one more line were readonly is disabled. This should not be necessary and I opened checkpoint-restore/criu#575 for tracking this.

@crosbymichael
Copy link
Member

crosbymichael commented Nov 19, 2018

LGTM

Approved with PullApprove

@cyphar
Copy link
Member

cyphar commented Nov 20, 2018

LGTM.

Approved with PullApprove

@cyphar cyphar merged commit bc0b047 into opencontainers:master Nov 20, 2018
cyphar added a commit that referenced this pull request Nov 20, 2018
  Small fixes for CRIU based test cases

LGTMs: @crosbymichael @cyphar
Closes #1936
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants